From: Charlie Jenkins <charlie@rivosinc.com>
To: Ian Rogers <irogers@google.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Mickaël Salaün" <mic@digikod.net>,
"Günther Noack" <gnoack@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"Guo Ren" <guoren@kernel.org>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"James Clark" <james.clark@linaro.org>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linux.dev>, "Jonathan Corbet" <corbet@lwn.net>,
"Björn Töpel" <bjorn@rivosinc.com>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-security-module@vger.kernel.org, bpf@vger.kernel.org,
linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 00/16] perf tools: Use generic syscall scripts for all archs
Date: Tue, 17 Dec 2024 17:11:09 -0800 [thread overview]
Message-ID: <Z2IhLZ8mfTWvbCvI@ghost> (raw)
In-Reply-To: <CAP-5=fWEUq_nLx7PUx96ixMrX0NqqF8W0EmXV9Zvc449zj0Z7A@mail.gmail.com>
On Tue, Dec 17, 2024 at 04:03:29PM -0800, Ian Rogers wrote:
> On Mon, Dec 16, 2024 at 10:39 PM Charlie Jenkins <charlie@rivosinc.com> wrote:
> >
> > Standardize the generation of syscall headers around syscall tables.
> > Previously each architecture independently selected how syscall headers
> > would be generated, or would not define a way and fallback onto
> > libaudit. Convert all architectures to use a standard syscall header
> > generation script and allow each architecture to override the syscall
> > table to use if they do not use the generic table.
> >
> > As a result of these changes, no architecture will require libaudit, and
> > so the fallback case of using libaudit is removed by this series.
> >
> > Testing:
> >
> > I have tested that the syscall mappings of id to name generation works
> > as expected for every architecture, but I have only validated that perf
> > trace compiles and runs as expected on riscv, arm64, and x86_64.
> >
> > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
>
> This is really great, thanks for taking the time for a substantial
> clean up. I had difficulty applying the patches to the perf-tools-next
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=perf-tools-next
> using patch and dealing with rejects I was able to test.
>
> Reviewed-by: Ian Rogers <irogers@google.com>
> On x86-64:
> Tested-by: Ian Rogers <irogers@google.com>
Thank you! I will base my next version on perf-tools-next.
- Charlie
>
> I think there are follow up patches that clean up the ABI, allow >1
> table at a time, .. but those things are best saved for a follow up.
>
> Thanks,
> Ian
>
> > ---
> > Changes in v3:
> > - Fix compiliation when OUTPUT is empty
> > - Correct unused headers to be .h instead of .c (Namhyung)
> > - Make variable definition of supported archs (Namhyung)
> > - Convert += into := for syscalls headers (Namhyung)
> > - Link to v2: https://lore.kernel.org/r/20241212-perf_syscalltbl-v2-0-f8ca984ffe40@rivosinc.com
> >
> > Changes in v2:
> > - Rebase onto 6.13-rc2
> > - Fix output path so it generates to /tools/perf/arch properly
> > - Link to v1: https://lore.kernel.org/r/20241104-perf_syscalltbl-v1-0-9adae5c761ef@rivosinc.com
> >
> > ---
> > Charlie Jenkins (16):
> > perf tools: Create generic syscall table support
> > perf tools: arc: Support generic syscall headers
> > perf tools: csky: Support generic syscall headers
> > perf tools: arm: Support syscall headers
> > perf tools: sh: Support syscall headers
> > perf tools: sparc: Support syscall headers
> > perf tools: xtensa: Support syscall header
> > perf tools: x86: Use generic syscall scripts
> > perf tools: alpha: Support syscall header
> > perf tools: parisc: Support syscall header
> > perf tools: arm64: Use syscall table
> > perf tools: loongarch: Use syscall table
> > perf tools: mips: Use generic syscall scripts
> > perf tools: powerpc: Use generic syscall table scripts
> > perf tools: s390: Use generic syscall table scripts
> > perf tools: Remove dependency on libaudit
> >
> > Documentation/admin-guide/workload-tracing.rst | 2 +-
> > tools/build/feature/Makefile | 4 -
> > tools/build/feature/test-libaudit.c | 11 -
> > tools/perf/Documentation/perf-check.txt | 1 -
> > tools/perf/Makefile.config | 39 +-
> > tools/perf/Makefile.perf | 12 +-
> > tools/perf/arch/alpha/entry/syscalls/Kbuild | 2 +
> > .../arch/alpha/entry/syscalls/Makefile.syscalls | 5 +
> > tools/perf/arch/alpha/entry/syscalls/syscall.tbl | 504 ++++++++++++++++++++
> > tools/perf/arch/alpha/include/syscall_table.h | 2 +
> > tools/perf/arch/arc/entry/syscalls/Kbuild | 2 +
> > .../perf/arch/arc/entry/syscalls/Makefile.syscalls | 3 +
> > tools/perf/arch/arc/include/syscall_table.h | 2 +
> > tools/perf/arch/arm/entry/syscalls/Kbuild | 4 +
> > .../perf/arch/arm/entry/syscalls/Makefile.syscalls | 2 +
> > tools/perf/arch/arm/entry/syscalls/syscall.tbl | 483 +++++++++++++++++++
> > tools/perf/arch/arm/include/syscall_table.h | 2 +
> > tools/perf/arch/arm64/Makefile | 22 -
> > tools/perf/arch/arm64/entry/syscalls/Kbuild | 3 +
> > .../arch/arm64/entry/syscalls/Makefile.syscalls | 6 +
> > tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 46 --
> > .../perf/arch/arm64/entry/syscalls/syscall_32.tbl | 476 +++++++++++++++++++
> > .../perf/arch/arm64/entry/syscalls/syscall_64.tbl | 1 +
> > tools/perf/arch/arm64/include/syscall_table.h | 8 +
> > tools/perf/arch/csky/entry/syscalls/Kbuild | 2 +
> > .../arch/csky/entry/syscalls/Makefile.syscalls | 3 +
> > tools/perf/arch/csky/include/syscall_table.h | 2 +
> > tools/perf/arch/loongarch/Makefile | 22 -
> > tools/perf/arch/loongarch/entry/syscalls/Kbuild | 2 +
> > .../loongarch/entry/syscalls/Makefile.syscalls | 3 +
> > .../arch/loongarch/entry/syscalls/mksyscalltbl | 45 --
> > tools/perf/arch/loongarch/include/syscall_table.h | 2 +
> > tools/perf/arch/mips/entry/syscalls/Kbuild | 2 +
> > .../arch/mips/entry/syscalls/Makefile.syscalls | 5 +
> > tools/perf/arch/mips/entry/syscalls/mksyscalltbl | 32 --
> > tools/perf/arch/mips/include/syscall_table.h | 2 +
> > tools/perf/arch/parisc/entry/syscalls/Kbuild | 3 +
> > .../arch/parisc/entry/syscalls/Makefile.syscalls | 6 +
> > tools/perf/arch/parisc/entry/syscalls/syscall.tbl | 463 +++++++++++++++++++
> > tools/perf/arch/parisc/include/syscall_table.h | 8 +
> > tools/perf/arch/powerpc/Makefile | 25 -
> > tools/perf/arch/powerpc/entry/syscalls/Kbuild | 3 +
> > .../arch/powerpc/entry/syscalls/Makefile.syscalls | 6 +
> > .../perf/arch/powerpc/entry/syscalls/mksyscalltbl | 39 --
> > tools/perf/arch/powerpc/include/syscall_table.h | 8 +
> > tools/perf/arch/riscv/Makefile | 22 -
> > tools/perf/arch/riscv/entry/syscalls/Kbuild | 2 +
> > .../arch/riscv/entry/syscalls/Makefile.syscalls | 4 +
> > tools/perf/arch/riscv/entry/syscalls/mksyscalltbl | 47 --
> > tools/perf/arch/riscv/include/syscall_table.h | 8 +
> > tools/perf/arch/s390/Makefile | 21 -
> > tools/perf/arch/s390/entry/syscalls/Kbuild | 2 +
> > .../arch/s390/entry/syscalls/Makefile.syscalls | 5 +
> > tools/perf/arch/s390/entry/syscalls/mksyscalltbl | 32 --
> > tools/perf/arch/s390/include/syscall_table.h | 2 +
> > tools/perf/arch/sh/entry/syscalls/Kbuild | 2 +
> > .../perf/arch/sh/entry/syscalls/Makefile.syscalls | 4 +
> > tools/perf/arch/sh/entry/syscalls/syscall.tbl | 472 +++++++++++++++++++
> > tools/perf/arch/sh/include/syscall_table.h | 2 +
> > tools/perf/arch/sparc/entry/syscalls/Kbuild | 3 +
> > .../arch/sparc/entry/syscalls/Makefile.syscalls | 5 +
> > tools/perf/arch/sparc/entry/syscalls/syscall.tbl | 514 +++++++++++++++++++++
> > tools/perf/arch/sparc/include/syscall_table.h | 8 +
> > tools/perf/arch/x86/Build | 1 -
> > tools/perf/arch/x86/Makefile | 25 -
> > tools/perf/arch/x86/entry/syscalls/Kbuild | 3 +
> > .../perf/arch/x86/entry/syscalls/Makefile.syscalls | 6 +
> > tools/perf/arch/x86/entry/syscalls/syscalltbl.sh | 42 --
> > tools/perf/arch/x86/include/syscall_table.h | 8 +
> > tools/perf/arch/xtensa/entry/syscalls/Kbuild | 2 +
> > .../arch/xtensa/entry/syscalls/Makefile.syscalls | 4 +
> > tools/perf/arch/xtensa/entry/syscalls/syscall.tbl | 439 ++++++++++++++++++
> > tools/perf/arch/xtensa/include/syscall_table.h | 2 +
> > tools/perf/builtin-check.c | 1 -
> > tools/perf/builtin-help.c | 2 -
> > tools/perf/builtin-trace.c | 30 --
> > tools/perf/check-headers.sh | 9 +
> > tools/perf/perf.c | 6 +-
> > tools/perf/scripts/Makefile.syscalls | 61 +++
> > tools/perf/scripts/syscalltbl.sh | 86 ++++
> > tools/perf/tests/make | 7 +-
> > tools/perf/util/env.c | 4 +-
> > tools/perf/util/generate-cmdlist.sh | 4 +-
> > tools/perf/util/syscalltbl.c | 90 +---
> > tools/scripts/syscall.tbl | 409 ++++++++++++++++
> > 85 files changed, 4102 insertions(+), 619 deletions(-)
> > ---
> > base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4
> > change-id: 20240913-perf_syscalltbl-6f98defcc6f5
> > --
> > - Charlie
> >
prev parent reply other threads:[~2024-12-18 1:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 6:32 [PATCH v3 00/16] perf tools: Use generic syscall scripts for all archs Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 01/16] perf tools: Create generic syscall table support Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 02/16] perf tools: arc: Support generic syscall headers Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 03/16] perf tools: csky: " Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 04/16] perf tools: arm: Support " Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 05/16] perf tools: sh: " Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 06/16] perf tools: sparc: " Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 07/16] perf tools: xtensa: Support syscall header Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 08/16] perf tools: x86: Use generic syscall scripts Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 09/16] perf tools: alpha: Support syscall header Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 10/16] perf tools: parisc: " Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 11/16] perf tools: arm64: Use syscall table Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 12/16] perf tools: loongarch: " Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 13/16] perf tools: mips: Use generic syscall scripts Charlie Jenkins
2024-12-17 6:32 ` [PATCH v3 14/16] perf tools: powerpc: Use generic syscall table scripts Charlie Jenkins
2024-12-17 6:33 ` [PATCH v3 15/16] perf tools: s390: " Charlie Jenkins
2024-12-17 6:33 ` [PATCH v3 16/16] perf tools: Remove dependency on libaudit Charlie Jenkins
2024-12-17 23:36 ` Ian Rogers
2024-12-18 0:02 ` Charlie Jenkins
2024-12-18 0:03 ` [PATCH v3 00/16] perf tools: Use generic syscall scripts for all archs Ian Rogers
2024-12-18 1:11 ` Charlie Jenkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2IhLZ8mfTWvbCvI@ghost \
--to=charlie@rivosinc.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bjorn@rivosinc.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=gnoack@google.com \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mic@digikod.net \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).