From: Stafford Horne <shorne@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Matt Turner" <mattst88@gmail.com>,
"Vineet Gupta" <vgupta@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Guo Ren" <guoren@kernel.org>,
"Brian Cain" <bcain@quicinc.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Michal Simek" <monstr@monstr.eu>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Jonas Bonn" <jonas@southpole.se>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Helge Deller" <deller@gmx.de>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
x86@kernel.org, "Borislav Petkov" <bp@alien8.de>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org,
sparclinux@vger.kernel.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
"Stefan Kristiansson" <stefan.kristiansson@saunalahti.fi>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
"Chris Zankel" <chris@zankel.net>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Christian Brauner" <brauner@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Youling Tang" <tangyouling@loongson.cn>,
"Tiezhu Yang" <yangtiezhu@loongson.cn>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Zhen Lei" <thunder.leizhen@huawei.com>,
"Xin Li" <xin3.li@intel.com>, "Nhat Pham" <nphamcs@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Marc Aurèle La France" <tsi@tuyoix.net>,
"Johannes Weiner" <hannes@cmpxchg.org>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally
Date: Fri, 11 Aug 2023 21:09:06 +0100 [thread overview]
Message-ID: <ZNaVYh2qi0VQQKWf@antec> (raw)
In-Reply-To: <20230810141947.1236730-17-arnd@kernel.org>
On Thu, Aug 10, 2023 at 04:19:34PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
,,,
> ---
> Below is the full list of warnings I see in defconfig builds for reference, these
> do not need to be part of the changelog.
...
> arch/openrisc/kernel/process.c:100:6: error: no previous prototype for 'arch_cpu_idle' [-Werror=missing-prototypes]
> arch/openrisc/kernel/process.c:240:21: error: no previous prototype for '__switch_to' [-Werror=missing-prototypes]
> arch/openrisc/kernel/ptrace.c:191:17: error: no previous prototype for 'do_syscall_trace_enter' [-Werror=missing-prototypes]
> arch/openrisc/kernel/ptrace.c:210:17: error: no previous prototype for 'do_syscall_trace_leave' [-Werror=missing-prototypes]
> arch/openrisc/kernel/signal.c:227:5: error: no previous prototype for 'do_signal' [-Werror=missing-prototypes]
> arch/openrisc/kernel/signal.c:293:1: error: no previous prototype for 'do_work_pending' [-Werror=missing-prototypes]
> arch/openrisc/kernel/signal.c:68:17: error: no previous prototype for '_sys_rt_sigreturn' [-Werror=missing-prototypes]
> arch/openrisc/kernel/time.c:111:25: error: no previous prototype for 'timer_interrupt' [-Werror=missing-prototypes]
> arch/openrisc/kernel/traps.c:146:6: error: no previous prototype for 'nommu_dump_state' [-Werror=missing-prototypes]
> arch/openrisc/kernel/traps.c:221:17: error: no previous prototype for 'die' [-Werror=missing-prototypes]
> arch/openrisc/kernel/traps.c:239:17: error: no previous prototype for 'unhandled_exception' [-Werror=missing-prototypes]
> arch/openrisc/kernel/traps.c:246:17: error: no previous prototype for 'do_fpe_trap' [-Werror=missing-prototypes]
> arch/openrisc/kernel/traps.c:268:17: error: no previous prototype for 'do_trap' [-Werror=missing-prototypes]
> arch/openrisc/kernel/traps.c:273:17: error: no previous prototype for 'do_unaligned_access' [-Werror=missing-prototypes]
> arch/openrisc/kernel/traps.c:286:17: error: no previous prototype for 'do_bus_fault' [-Werror=missing-prototypes]
> arch/openrisc/kernel/traps.c:462:17: error: no previous prototype for 'do_illegal_instruction' [-Werror=missing-prototypes]
> arch/openrisc/kernel/traps.c:67:6: error: no previous prototype for 'show_registers' [-Werror=missing-prototypes]
> arch/openrisc/mm/fault.c:44:17: error: no previous prototype for 'do_page_fault' [-Werror=missing-prototypes]
> arch/openrisc/mm/tlb.c:188:13: error: no previous prototype for 'tlb_init' [-Werror=missing-prototypes]
I'll try to get these fixed for 6.6. I was looking at them recently but did not
actually make any changes and just put on my TODO. Your series moves it up in
priority and it should be easy to get the fixes out.
...
> diff --git a/init/Kconfig b/init/Kconfig
> index 639e8a3363c30..80cd67c0d7fa4 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -170,6 +170,16 @@ config WERROR
>
> If in doubt, say Y.
>
> +config WNO_MISSING_PROTOTYPES
> + bool "Hide -Wmissing-prototype warnings in arch code"
> + default WERROR || !COMPILE_TEST
> + help
> + Some architectures have not yet eliminated all warnings for
> + missing prototypes in their core code and will produce a lot
> + of output for these. Ideally these should all be addresszed
addressed
> + by individual bugfix patches, but in the meantime saying 'y'
> + will skip that output.
> +
> config UAPI_HEADER_TEST
> bool "Compile test UAPI headers"
> depends on HEADERS_INSTALL && CC_CAN_LINK
-Stafford
next prev parent reply other threads:[~2023-08-11 20:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 14:19 [PATCH 00/17] -Wmissing-prototype warning fixes Arnd Bergmann
2023-08-10 14:19 ` [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes Arnd Bergmann
2023-08-11 22:10 ` Masahiro Yamada
2023-08-12 7:34 ` Arnd Bergmann
2023-08-10 14:19 ` [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally Arnd Bergmann
[not found] ` <e0c2f7b1-b137-fbd3-aa28-808498eb8e3f@csgroup.eu>
2023-08-10 15:21 ` Arnd Bergmann
2023-08-10 15:59 ` Helge Deller
2023-08-10 19:15 ` Arnd Bergmann
2023-08-11 2:33 ` Guo Ren
2023-08-11 18:25 ` Vineet Gupta
2023-08-11 20:09 ` Stafford Horne [this message]
2023-08-12 8:02 ` Arnd Bergmann
2023-08-16 14:38 ` [PATCH 00/17] -Wmissing-prototype warning fixes Palmer Dabbelt
2023-08-25 1:12 ` (subset) " Martin K. Petersen
2023-08-25 1:30 ` Michael Schmitz
2023-08-25 7:39 ` Geert Uytterhoeven
2023-08-25 22:44 ` Michael Schmitz
2023-08-28 6:42 ` Geert Uytterhoeven
2023-08-28 8:07 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNaVYh2qi0VQQKWf@antec \
--to=shorne@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bcain@quicinc.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=christophe.leroy@csgroup.eu \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dinguyen@kernel.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hca@linux.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=kernel@xen0n.name \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=loongarch@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=mattst88@gmail.com \
--cc=mhiramat@kernel.org \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nphamcs@gmail.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=rdunlap@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tangyouling@loongson.cn \
--cc=thunder.leizhen@huawei.com \
--cc=tsbogend@alpha.franken.de \
--cc=tsi@tuyoix.net \
--cc=vgupta@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
--cc=yangtiezhu@loongson.cn \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).