From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8229DEE6423 for ; Fri, 15 Sep 2023 06:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232447AbjIOGxV (ORCPT ); Fri, 15 Sep 2023 02:53:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232401AbjIOGxU (ORCPT ); Fri, 15 Sep 2023 02:53:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 288562735 for ; Thu, 14 Sep 2023 23:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694760734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mil5Lpt/AWqT9ucliicGrw0zms2aJ9EQRoMaWTOR9i0=; b=SV2hrhHvksiGOiy9I7WRaF35D2wblp2MAGwvZXJy8/e62OLxYDhjfnv34Domv7DnICanJx JxHeLzM/tk3Jxrc0h8nQe5qUt3KmW6pTiaV1CCbkAWpApE7vN36lUdoJ4n/7jkX550DDdo OBrRpKaJ5YLeV7R17TKY+W6v5vvJPbI= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-kWvCos42OpqVRKh-MhmpUw-1; Fri, 15 Sep 2023 02:52:11 -0400 X-MC-Unique: kWvCos42OpqVRKh-MhmpUw-1 Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-6bee94ff9e9so2251094a34.1 for ; Thu, 14 Sep 2023 23:52:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694760730; x=1695365530; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mil5Lpt/AWqT9ucliicGrw0zms2aJ9EQRoMaWTOR9i0=; b=xNh4ru8/joxloNlHm236p9V1a+ccXDEGSMdv5DOjo/nOl9P75Cup8qsGfepxTjR4LF bm7e5XfEklr2e9w3ANlii0Y7JI0A6z3i98muW1xl/Xqb1KWcwy43azBJdLs2U/AxhgSk S2X2lW5XeIx0rO1PTEzpp2OEb3NJpgYnFm+5ryzOk3+si8LKPP9n7z16NyWJiDGcuRFL otNR6Fqem6ad894stJENBqXYQccg+lo8IK4307fKfhPKenH9ItcSOIlZgLXZpU/me5w3 8Jzd/GhVmQ8ELxq3P3qhf/f9bIuigwDZmDG3c+IxlUDG7G39YhpvXq49amhep8eAzkF/ YShw== X-Gm-Message-State: AOJu0YyJG7E3y2ALkBqbnTg9AdgoQTjH73nREw3JZLjT+gFKcVSuZxOx ioZyNdGT9wVrE9oIWHEmxYWyBzFzMYAVQEeJlPsXGLdsIqN2/Z1r39hr9Lf33KheCxK1JHpyY6P 6gF6hZ+EfiNM8vgm2BVy9Iw== X-Received: by 2002:a9d:61d2:0:b0:6b8:691e:ec53 with SMTP id h18-20020a9d61d2000000b006b8691eec53mr692096otk.11.1694760730713; Thu, 14 Sep 2023 23:52:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5XKtDZPdccOWeAcP3oR13oWpgp0h0NQCTbBcXsI+ozwyS91W+C45E6K0TtmaCpK+EoMojSA== X-Received: by 2002:a9d:61d2:0:b0:6b8:691e:ec53 with SMTP id h18-20020a9d61d2000000b006b8691eec53mr692067otk.11.1694760730535; Thu, 14 Sep 2023 23:52:10 -0700 (PDT) Received: from redhat.com ([2804:1b3:a803:4ff9:7c29:fe41:6aa7:43df]) by smtp.gmail.com with ESMTPSA id a9-20020a056830008900b006b9b6aea237sm1367919oto.80.2023.09.14.23.52.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 23:52:10 -0700 (PDT) Date: Fri, 15 Sep 2023 03:52:00 -0300 From: Leonardo Bras To: guoren@kernel.org Cc: paul.walmsley@sifive.com, anup@brainfault.org, peterz@infradead.org, mingo@redhat.com, will@kernel.org, palmer@rivosinc.com, longman@redhat.com, boqun.feng@gmail.com, tglx@linutronix.de, paulmck@kernel.org, rostedt@goodmis.org, rdunlap@infradead.org, catalin.marinas@arm.com, conor.dooley@microchip.com, xiaoguang.xing@sophgo.com, bjorn@rivosinc.com, alexghiti@rivosinc.com, keescook@chromium.org, greentime.hu@sifive.com, ajones@ventanamicro.com, jszhang@kernel.org, wefu@redhat.com, wuwei2016@iscas.ac.cn, linux-arch@vger.kernel.org, linux-riscv@lists.infradead.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-csky@vger.kernel.org, Guo Ren Subject: Re: [PATCH V11 17/17] RISC-V: paravirt: pvqspinlock: KVM: Implement kvm_sbi_ext_pvlock_kick_cpu() Message-ID: References: <20230910082911.3378782-1-guoren@kernel.org> <20230910082911.3378782-18-guoren@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230910082911.3378782-18-guoren@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Sun, Sep 10, 2023 at 04:29:11AM -0400, guoren@kernel.org wrote: > From: Guo Ren > > We only need to call the kvm_vcpu_kick() and bring target_vcpu > from the halt state. No irq raised, no other request, just a pure > vcpu_kick. > > Signed-off-by: Guo Ren > Signed-off-by: Guo Ren > --- > arch/riscv/kvm/vcpu_sbi_pvlock.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/riscv/kvm/vcpu_sbi_pvlock.c b/arch/riscv/kvm/vcpu_sbi_pvlock.c > index 544a456c5041..914fc58aedfe 100644 > --- a/arch/riscv/kvm/vcpu_sbi_pvlock.c > +++ b/arch/riscv/kvm/vcpu_sbi_pvlock.c > @@ -12,6 +12,24 @@ > #include > #include > > +static int kvm_sbi_ext_pvlock_kick_cpu(struct kvm_vcpu *vcpu) > +{ > + struct kvm_cpu_context *cp = &vcpu->arch.guest_context; > + struct kvm *kvm = vcpu->kvm; > + struct kvm_vcpu *target; > + > + target = kvm_get_vcpu_by_id(kvm, cp->a0); > + if (!target) > + return SBI_ERR_INVALID_PARAM; > + > + kvm_vcpu_kick(target); > + > + if (READ_ONCE(target->ready)) > + kvm_vcpu_yield_to(target); > + > + return SBI_SUCCESS; > +} > + > static int kvm_sbi_ext_pvlock_handler(struct kvm_vcpu *vcpu, struct kvm_run *run, > struct kvm_vcpu_sbi_return *retdata) > { > @@ -21,6 +39,7 @@ static int kvm_sbi_ext_pvlock_handler(struct kvm_vcpu *vcpu, struct kvm_run *run > > switch (funcid) { > case SBI_EXT_PVLOCK_KICK_CPU: > + ret = kvm_sbi_ext_pvlock_kick_cpu(vcpu); > break; > default: > ret = SBI_ERR_NOT_SUPPORTED; > -- > 2.36.1 > LGTM: Reviewed-by: Leonardo Bras Thanks! Leo