From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="phbhpdMh" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBA1910A; Thu, 14 Dec 2023 10:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=az+3j+x28e0MvEnutvjaU0xgwYkokn4xM04tjgXdKPA=; b=phbhpdMhqApnRG8+xq5SsWLNms MNH+uNHn31DAvev+yUe5VGnPqUaT9bPvubmCX3om2ul0kSEB34STohtRy7PXweQ4YPCipcktJSMEO EBmq3tDRmt/HEh2JuB5zU7YMY+rQShiO7J5+Z0TXUhAfd7WWhZG5STwBTj2gxUJ9dTu2ipDGzRQgg dT15U01Mg3344Q2FfLVMrKt74o4PXNfCDyX/lfc30yk8prE2s4X4N+PrCMYciv5V+Bgw52q1Hrg9u 3qABnwM119UdNsI38XnYsRQ6trF/eq3eQX7ofT+05+xvQecv/9GT3PQyQELGxIppvwV6yuwfsmlCH Z178ezDA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42168) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rDq3l-0001pA-0r; Thu, 14 Dec 2023 18:03:45 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rDq3n-0002l5-AY; Thu, 14 Dec 2023 18:03:47 +0000 Date: Thu, 14 Dec 2023 18:03:47 +0000 From: "Russell King (Oracle)" To: Jonathan Cameron Cc: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, acpica-devel@lists.linuxfoundation.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, James Morse Subject: Re: [PATCH RFC v3 07/21] ACPI: Rename acpi_processor_hotadd_init and remove pre-processor guards Message-ID: References: <20231214174337.000042a4@Huawei.com> Precedence: bulk X-Mailing-List: linux-csky@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214174337.000042a4@Huawei.com> Sender: Russell King (Oracle) On Thu, Dec 14, 2023 at 05:43:37PM +0000, Jonathan Cameron wrote: > On Wed, 13 Dec 2023 12:49:47 +0000 > Russell King (Oracle) wrote: > > > From: James Morse > > > > acpi_processor_hotadd_init() will make a CPU present by mapping it > > based on its hardware id. > > > > 'hotadd_init' is ambiguous once there are two different behaviours > > for cpu hotplug. This is for toggling the _STA present bit. Subsequent > > patches will add support for toggling the _STA enabled bit, named > > acpi_processor_make_enabled(). > > > > Rename it acpi_processor_make_present() to make it clear this is > > for CPUs that were not previously present. > > > > Expose the function prototypes it uses to allow the preprocessor > > guards to be removed. The IS_ENABLED() check will let the compiler > > dead-code elimination pass remove this if it isn't going to be > > used. > > > > Signed-off-by: James Morse > > Tested-by: Miguel Luis > > Tested-by: Vishnu Pajjuri > > Tested-by: Jianyong Wu > > --- > > Outstanding comments: > > https://lore.kernel.org/r/20230914151720.00007105@Huawei.com > > If it's not caused a build warning yet, chances are high this is fine. > > Reviewed-by: Jonathan Cameron > > > https://lore.kernel.org/r/b8f430c1-c30f-191f-18c6-f750fa6ba476@redhat.com > > For this comment, we use IS_ENABLED() in multiple places in the kernel in > > this way, and it isn't a problem. Yes, for both of these comments, I think they aren't something that needs any action - these patches have been published in my tree since October, and that is subject to the kernel build bot which hasn't found any issues. So, I'll add your r-b, add my s-o-b, and remove the "outstanding comments" from this patch. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!