linux-csky.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Uladzislau Rezki <urezki@gmail.com>
To: Shubhang Kaushik OS <Shubhang@os.amperecomputing.com>
Cc: Uladzislau Rezki <urezki@gmail.com>,
	"ampere-linux-kernel@lists.amperecomputing.com"
	<ampere-linux-kernel@lists.amperecomputing.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"cl@linux.com" <cl@linux.com>, "corbet@lwn.net" <corbet@lwn.net>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"guoren@kernel.org" <guoren@kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"xiongwei.song@windriver.com" <xiongwei.song@windriver.com>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
	"willy@infradead.org" <willy@infradead.org>
Subject: Re: [PATCH v4] vmalloc: Modify the alloc_vmap_area() error message for better diagnostics
Date: Tue, 11 Jun 2024 20:05:37 +0200	[thread overview]
Message-ID: <ZmiR8STlyXEahzqy@pc636> (raw)
In-Reply-To: <CH2PR01MB58942C3696E4FD0181782F4DF5C72@CH2PR01MB5894.prod.exchangelabs.com>

>
> This is intentional.  When 'addr' equals 'vend' the overflow path is triggered, but then the 'vstart' and 'vend'
> values are not carried in the overflow path - making them point to no address. That is the reason 'addr' is used
> in the warning message to specify the restrictive range - that gets assigned to 'va_start' and 'va_end' in the ideal case.
> 
What do you mean when you say:
"but then the 'vstart' and 'vend' values are not carried in the overflow path - making them point to no address."

From your commit message: "With the update, the output gets modified to
include the function parameters along with the start and end of the virtual
memory range allowed."

i see that you would like to print an allowed range. Thus an allowed
range is specified by "vstart" and "vend", i.e.:


      vstart  vend
<-------|------|------> vmap spase

an allocation must be served between "vstart" and "vend". So, according to
your commit message that range should be printed in case of error.

Now you print, "vend" address and "vend + size" one. I do not follow why
you need it. Could you please explain?

--
Uladzislau Rezki

      reply	other threads:[~2024-06-11 18:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 17:22 [PATCH v4] vmalloc: Modify the alloc_vmap_area() error message for better diagnostics Shubhang Kaushik OS
2024-06-11 10:09 ` Uladzislau Rezki
2024-06-11 17:44   ` Shubhang Kaushik OS
2024-06-11 18:05     ` Uladzislau Rezki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmiR8STlyXEahzqy@pc636 \
    --to=urezki@gmail.com \
    --cc=Shubhang@os.amperecomputing.com \
    --cc=akpm@linux-foundation.org \
    --cc=ampere-linux-kernel@lists.amperecomputing.com \
    --cc=cl@linux.com \
    --cc=corbet@lwn.net \
    --cc=guoren@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=willy@infradead.org \
    --cc=xiongwei.song@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).