From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: "Ian Rogers" <irogers@google.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linux.dev>, "Guo Ren" <guoren@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Nick Terrell" <terrelln@fb.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Kees Cook" <keescook@chromium.org>,
"Andrei Vagin" <avagin@google.com>,
"Athira Jajeev" <atrajeev@linux.vnet.ibm.com>,
"Oliver Upton" <oliver.upton@linux.dev>,
"Ze Gao" <zegao2021@gmail.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-riscv@lists.infradead.org, coresight@lists.linaro.org,
rust-for-linux@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v1 0/7] Refactor perf python module build
Date: Thu, 13 Jun 2024 11:15:37 -0300 [thread overview]
Message-ID: <Zmr_CfhYsvKePZFt@x1> (raw)
In-Reply-To: <bdf1ab6e-b887-4182-a0ae-7653bd835907@arm.com>
On Thu, Jun 13, 2024 at 10:27:15AM +0100, James Clark wrote:
> On 12/06/2024 19:31, Ian Rogers wrote:
> > Refactor the perf python module build to instead of building C files
> > it links libraries. To support this make static libraries for tests,
> > ui, util and pmu-events. Doing this allows fewer functions to be
> > stubbed out, importantly parse_events is no longer stubbed out which
> > will improve the ability to work with heterogeneous cores.
> >
> > Patches 1 to 5 add static libraries for existing parts of the perf
> > build.
> >
> > Patch 6 adds the python build using libraries rather than C source
> > files.
> >
> > Patch 7 cleans up the python dependencies and removes the no longer
> > needed python-ext-sources.
> >
>
> Reviewed-by: James Clark <james.clark@arm.com>
>
> It does require a clean build to avoid some -fPIC errors presumably
> because not everything that requires it gets rebuilt, for anyone who
> gets stuck on that.
We need to find a way to avoid requiring the 'make clean' :-/
- Arnaldo
> > Ian Rogers (7):
> > perf ui: Make ui its own library
> > perf pmu-events: Make pmu-events a library
> > perf test: Make tests its own library
> > perf bench: Make bench its own library
> > perf util: Make util its own library
> > perf python: Switch module to linking libraries from building source
> > perf python: Clean up build dependencies
> >
> > tools/perf/Build | 14 +-
> > tools/perf/Makefile.config | 5 +
> > tools/perf/Makefile.perf | 66 ++-
> > tools/perf/arch/Build | 4 +-
> > tools/perf/arch/arm/Build | 4 +-
> > tools/perf/arch/arm/tests/Build | 8 +-
> > tools/perf/arch/arm/util/Build | 10 +-
> > tools/perf/arch/arm64/Build | 4 +-
> > tools/perf/arch/arm64/tests/Build | 8 +-
> > tools/perf/arch/arm64/util/Build | 20 +-
> > tools/perf/arch/csky/Build | 2 +-
> > tools/perf/arch/csky/util/Build | 6 +-
> > tools/perf/arch/loongarch/Build | 2 +-
> > tools/perf/arch/loongarch/util/Build | 8 +-
> > tools/perf/arch/mips/Build | 2 +-
> > tools/perf/arch/mips/util/Build | 6 +-
> > tools/perf/arch/powerpc/Build | 4 +-
> > tools/perf/arch/powerpc/tests/Build | 6 +-
> > tools/perf/arch/powerpc/util/Build | 24 +-
> > tools/perf/arch/riscv/Build | 2 +-
> > tools/perf/arch/riscv/util/Build | 8 +-
> > tools/perf/arch/s390/Build | 2 +-
> > tools/perf/arch/s390/util/Build | 16 +-
> > tools/perf/arch/sh/Build | 2 +-
> > tools/perf/arch/sh/util/Build | 2 +-
> > tools/perf/arch/sparc/Build | 2 +-
> > tools/perf/arch/sparc/util/Build | 2 +-
> > tools/perf/arch/x86/Build | 6 +-
> > tools/perf/arch/x86/tests/Build | 20 +-
> > tools/perf/arch/x86/util/Build | 42 +-
> > tools/perf/bench/Build | 46 +-
> > tools/perf/scripts/Build | 4 +-
> > tools/perf/scripts/perl/Perf-Trace-Util/Build | 2 +-
> > .../perf/scripts/python/Perf-Trace-Util/Build | 2 +-
> > tools/perf/tests/Build | 140 +++----
> > tools/perf/tests/workloads/Build | 12 +-
> > tools/perf/ui/Build | 18 +-
> > tools/perf/ui/browsers/Build | 14 +-
> > tools/perf/ui/tui/Build | 8 +-
> > tools/perf/util/Build | 394 +++++++++---------
> > tools/perf/util/arm-spe-decoder/Build | 2 +-
> > tools/perf/util/cs-etm-decoder/Build | 2 +-
> > tools/perf/util/hisi-ptt-decoder/Build | 2 +-
> > tools/perf/util/intel-pt-decoder/Build | 2 +-
> > tools/perf/util/perf-regs-arch/Build | 18 +-
> > tools/perf/util/python-ext-sources | 53 ---
> > tools/perf/util/python.c | 271 +++++-------
> > tools/perf/util/scripting-engines/Build | 4 +-
> > tools/perf/util/setup.py | 33 +-
> > 49 files changed, 612 insertions(+), 722 deletions(-)
> > delete mode 100644 tools/perf/util/python-ext-sources
> >
next prev parent reply other threads:[~2024-06-13 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 18:31 [PATCH v1 0/7] Refactor perf python module build Ian Rogers
2024-06-12 18:31 ` [PATCH v1 1/7] perf ui: Make ui its own library Ian Rogers
2024-06-12 18:32 ` [PATCH v1 2/7] perf pmu-events: Make pmu-events a library Ian Rogers
2024-06-12 18:32 ` [PATCH v1 3/7] perf test: Make tests its own library Ian Rogers
2024-06-12 18:32 ` [PATCH v1 4/7] perf bench: Make bench " Ian Rogers
2024-06-12 18:32 ` [PATCH v1 5/7] perf util: Make util " Ian Rogers
2024-06-12 18:32 ` [PATCH v1 6/7] perf python: Switch module to linking libraries from building source Ian Rogers
2024-06-12 18:32 ` [PATCH v1 7/7] perf python: Clean up build dependencies Ian Rogers
2024-06-13 9:27 ` [PATCH v1 0/7] Refactor perf python module build James Clark
2024-06-13 14:15 ` Arnaldo Carvalho de Melo [this message]
2024-06-13 15:10 ` James Clark
2024-06-13 16:55 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zmr_CfhYsvKePZFt@x1 \
--to=acme@kernel.org \
--cc=a.hindborg@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=alex.gaynor@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=aliceryhl@google.com \
--cc=aou@eecs.berkeley.edu \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=avagin@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=coresight@lists.linaro.org \
--cc=gary@garyguo.net \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=keescook@chromium.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ojeda@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=terrelln@fb.com \
--cc=wedsonaf@gmail.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=zegao2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).