From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54FE51BAEC1; Mon, 9 Sep 2024 14:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725892677; cv=none; b=KIsT2YW36IvIZjWRYY6i2sCsuT64syX9tO7oAhhvlE27OolZkrrXL7NosGe7EOm+ge2JbIkcaV6zSgV7ZoyWBTuBTHlXBi10Sl+qifnneDqdtIUhREe/45BnfPI2rSqdX774K/T5J0lsq4f/1LHRF+L+mgfteBHO+7z+mXyg0A4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725892677; c=relaxed/simple; bh=MghDFbPAU9zqqkhW3Xw5vWmg1dmDiUK7SCkrMyPD7PA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JCrt0N8FCr4Cqblw2Wk/OCDBZppKS5+jCx7bQkTuQBEOX0/uQkX8bY1RAM61faHeO5ApW+b5Zft9s66hMIvwWcUM2QYsfbzDZyWIN5eT2z8ts8ABvtM+PdiFLM3h+Z0kNBM/g9iVD+8cqQyb8KsU3sbgtXNFo572veH7rtrIv/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Fs6Al/RP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Fs6Al/RP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BA38C4CEC5; Mon, 9 Sep 2024 14:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725892676; bh=MghDFbPAU9zqqkhW3Xw5vWmg1dmDiUK7SCkrMyPD7PA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fs6Al/RPqqDYAd+lPeXebcBiEsV8ZcvYqHnhgbekPtDgt19OlBHjiP9gQSdGe9afm E6dAjll1IYePf87BqvuUHZojSOISa9K5xqnGdYsjKjKAxmrH58TOhb7yDaJfDepFBa KmFe19pfYgaP0P6SOasN93vKsvEqQdqzY5UZFrT5OYDRUwY9bZOJ0yO3EIutfG5ADs 9/aQXVlZzbQSnDoIg63nYDc2lsJ+5/3DsjcdPHAdeypnZ/+PEaSwQCoG2ocV6cZ8IN 5SSH1gwzGe/PyYVHsa/teqwYFCWwEBH8MNluTcSCH96QK9eENqGcAFK+i9m860tlOX EjTv1+plHkaMQ== Date: Mon, 9 Sep 2024 17:34:48 +0300 From: Mike Rapoport To: Peter Zijlstra Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text Message-ID: References: <20240909064730.3290724-1-rppt@kernel.org> <20240909064730.3290724-7-rppt@kernel.org> <20240909092923.GB4723@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-csky@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909092923.GB4723@noisy.programming.kicks-ass.net> On Mon, Sep 09, 2024 at 11:29:23AM +0200, Peter Zijlstra wrote: > On Mon, Sep 09, 2024 at 09:47:28AM +0300, Mike Rapoport wrote: > > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > > index 8da0e66ca22d..563d9a890ce2 100644 > > --- a/arch/x86/kernel/ftrace.c > > +++ b/arch/x86/kernel/ftrace.c > > > @@ -654,4 +656,15 @@ void ftrace_graph_func(unsigned long ip, unsigned long parent_ip, > > } > > #endif > > > > +void ftrace_swap_func(void *a, void *b, int n) > > +{ > > + unsigned long t; > > + > > + WARN_ON_ONCE(n != sizeof(t)); > > + > > + t = *((unsigned long *)a); > > + text_poke_copy(a, b, sizeof(t)); > > + text_poke_copy(b, &t, sizeof(t)); > > +} > > This is insane, just force BUILDTIME_MCOUNT_SORT The comment in ftrace.c says "... while mcount loc in modules can not be sorted at build time" I don't know enough about objtool, but I'd presume it's because the sorting should happen after relocations, no? -- Sincerely yours, Mike.