From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Guo Ren <guoren@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Nick Terrell <terrelln@fb.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Changbin Du <changbin.du@huawei.com>,
Guilherme Amadio <amadio@gentoo.org>,
Yang Jihong <yangjihong@bytedance.com>,
Aditya Gupta <adityag@linux.ibm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Bibo Mao <maobibo@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Kajol Jain <kjain@linux.ibm.com>,
Atish Patra <atishp@rivosinc.com>,
Shenlin Liang <liangshenlin@eswincomputing.com>,
Anup Patel <anup@brainfault.org>,
Oliver Upton <oliver.upton@linux.dev>,
"Steinar H. Gunderson" <sesse@google.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Chen Pei <cp0613@linux.alibaba.com>,
Dima Kogan <dima@secretsauce.net>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 00/11] Libdw/dwarf build clean up
Date: Fri, 18 Oct 2024 10:15:48 -0700 [thread overview]
Message-ID: <ZxKXxKji_LhtLLpu@google.com> (raw)
In-Reply-To: <20241017001354.56973-1-irogers@google.com>
On Wed, Oct 16, 2024 at 05:13:43PM -0700, Ian Rogers wrote:
> These patches were originally on top of:
> https://lore.kernel.org/lkml/20240924003720.617258-1-irogers@google.com/
> where it was pointed out that a lot of the libdw conditional
> compilation was due to features that have now been standard for 10 or
> 15 years. The patches remove the conditional compilation assuming the
> features are in libdw where the feature test is expanded to check
> there pressence. The patch series is now on top of:
> https://lore.kernel.org/lkml/20241016235622.52166-1-irogers@google.com/
>
> In the Makefile code, and for `perf record --call-graph`, dwarf tends
> to mean unwind or libdw support for dwarf things. To make it clearer
> when dwarf really just means libdw numerous build variables and
> defines are renamed.
>
> There is some tech debt in the changes as perf check still reports the
> values using the old name and for features that are no longer
> tested. This can be cleanup for another day.
>
> v3: Move PERF_HAVE_DWARF_REGS cleanup to follow up patch series. Add
> build fix from patch series these changes are on top of.
> v2: Instead of renaming PERF_HAVE_DWARF_REGS to PERF_HAVE_LIBDW_REGS,
> remove it.
>
> Ian Rogers (11):
> perf build: Fix LIBDW_DIR
> perf build: Rename NO_DWARF to NO_LIBDW
> perf build: Remove defined but never used variable
> perf build: Rename test-dwarf to test-libdw
> perf build: Combine libdw-dwarf-unwind into libdw feature tests
> perf build: Combine test-dwarf-getlocations into test-libdw
> perf build: Combine test-dwarf-getcfi into test-libdw
> perf probe: Move elfutils support check to libdw check
> perf libdw: Remove unnecessary defines
> perf build: Rename HAVE_DWARF_SUPPORT to HAVE_LIBDW_SUPPORT
> perf build: Rename CONFIG_DWARF to CONFIG_LIBDW
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> tools/build/Makefile.feature | 11 +---
> tools/build/feature/Makefile | 24 ++------
> tools/build/feature/test-all.c | 16 +-----
> tools/build/feature/test-dwarf.c | 11 ----
> tools/build/feature/test-dwarf_getcfi.c | 9 ---
> tools/build/feature/test-dwarf_getlocations.c | 13 -----
> tools/build/feature/test-libdw-dwarf-unwind.c | 14 -----
> tools/build/feature/test-libdw.c | 56 +++++++++++++++++++
> tools/perf/Documentation/perf-check.txt | 6 +-
> tools/perf/Makefile.config | 47 +++++-----------
> tools/perf/Makefile.perf | 2 +-
> tools/perf/arch/arm/Makefile | 2 +-
> tools/perf/arch/arm/util/Build | 2 +-
> tools/perf/arch/arm64/Makefile | 2 +-
> tools/perf/arch/arm64/util/Build | 2 +-
> tools/perf/arch/csky/Makefile | 2 +-
> tools/perf/arch/csky/util/Build | 2 +-
> tools/perf/arch/loongarch/Makefile | 2 +-
> tools/perf/arch/loongarch/util/Build | 2 +-
> tools/perf/arch/mips/Makefile | 2 +-
> tools/perf/arch/mips/util/Build | 2 +-
> tools/perf/arch/powerpc/Makefile | 2 +-
> .../perf/arch/powerpc/annotate/instructions.c | 4 +-
> tools/perf/arch/powerpc/util/Build | 4 +-
> tools/perf/arch/riscv/Makefile | 2 +-
> tools/perf/arch/riscv/util/Build | 2 +-
> tools/perf/arch/s390/Makefile | 2 +-
> tools/perf/arch/s390/util/Build | 2 +-
> tools/perf/arch/sh/Makefile | 2 +-
> tools/perf/arch/sh/util/Build | 2 +-
> tools/perf/arch/sparc/Makefile | 2 +-
> tools/perf/arch/sparc/util/Build | 2 +-
> tools/perf/arch/x86/Makefile | 2 +-
> tools/perf/arch/x86/annotate/instructions.c | 2 +-
> tools/perf/arch/x86/util/Build | 2 +-
> tools/perf/arch/xtensa/Makefile | 2 +-
> tools/perf/arch/xtensa/util/Build | 2 +-
> tools/perf/builtin-annotate.c | 2 +-
> tools/perf/builtin-check.c | 6 +-
> tools/perf/builtin-probe.c | 14 ++---
> tools/perf/builtin-report.c | 4 +-
> tools/perf/util/Build | 12 ++--
> tools/perf/util/annotate-data.h | 8 +--
> tools/perf/util/debuginfo.h | 6 +-
> tools/perf/util/disasm.c | 4 +-
> tools/perf/util/disasm.h | 4 +-
> tools/perf/util/dwarf-aux.c | 6 --
> tools/perf/util/dwarf-aux.h | 54 ------------------
> tools/perf/util/genelf.c | 4 +-
> tools/perf/util/genelf.h | 2 +-
> tools/perf/util/include/dwarf-regs.h | 6 +-
> tools/perf/util/probe-event.c | 4 +-
> tools/perf/util/probe-finder.c | 6 --
> tools/perf/util/probe-finder.h | 6 +-
> 54 files changed, 154 insertions(+), 259 deletions(-)
> delete mode 100644 tools/build/feature/test-dwarf.c
> delete mode 100644 tools/build/feature/test-dwarf_getcfi.c
> delete mode 100644 tools/build/feature/test-dwarf_getlocations.c
> delete mode 100644 tools/build/feature/test-libdw-dwarf-unwind.c
> create mode 100644 tools/build/feature/test-libdw.c
>
> --
> 2.47.0.105.g07ac214952-goog
>
next prev parent reply other threads:[~2024-10-18 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 0:13 [PATCH v3 00/11] Libdw/dwarf build clean up Ian Rogers
2024-10-17 0:13 ` [PATCH v3 01/11] perf build: Fix LIBDW_DIR Ian Rogers
2024-10-17 0:13 ` [PATCH v3 02/11] perf build: Rename NO_DWARF to NO_LIBDW Ian Rogers
2024-10-17 0:13 ` [PATCH v3 03/11] perf build: Remove defined but never used variable Ian Rogers
2024-10-17 0:13 ` [PATCH v3 04/11] perf build: Rename test-dwarf to test-libdw Ian Rogers
2024-10-17 0:13 ` [PATCH v3 05/11] perf build: Combine libdw-dwarf-unwind into libdw feature tests Ian Rogers
2024-10-17 0:13 ` [PATCH v3 06/11] perf build: Combine test-dwarf-getlocations into test-libdw Ian Rogers
2024-10-17 0:13 ` [PATCH v3 07/11] perf build: Combine test-dwarf-getcfi " Ian Rogers
2024-10-17 0:13 ` [PATCH v3 08/11] perf probe: Move elfutils support check to libdw check Ian Rogers
2024-10-17 0:13 ` [PATCH v3 09/11] perf libdw: Remove unnecessary defines Ian Rogers
2024-10-17 0:13 ` [PATCH v3 10/11] perf build: Rename HAVE_DWARF_SUPPORT to HAVE_LIBDW_SUPPORT Ian Rogers
2024-10-17 0:13 ` [PATCH v3 11/11] perf build: Rename CONFIG_DWARF to CONFIG_LIBDW Ian Rogers
2024-10-18 17:15 ` Namhyung Kim [this message]
2024-10-19 16:23 ` [PATCH v3 00/11] Libdw/dwarf build clean up Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxKXxKji_LhtLLpu@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adityag@linux.ibm.com \
--cc=adrian.hunter@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=amadio@gentoo.org \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=changbin.du@huawei.com \
--cc=chenhuacai@kernel.org \
--cc=cp0613@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=dima@secretsauce.net \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linux.dev \
--cc=liangshenlin@eswincomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@treblig.org \
--cc=maobibo@loongson.cn \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=sesse@google.com \
--cc=terrelln@fb.com \
--cc=will@kernel.org \
--cc=yangjihong@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).