Re: [PATCH 07/17] clone3: drop __ARCH_WANT_SYS_CLONE3 macro

Geert Uytterhoeven
2024-07-05T08:13:09Z

On Thu, Jul 4, 2024 at 4:38 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When clone3() was introduced, it was not obvious how each architecture
> deals with setting up the stack and keeping the register contents in
> a fork()-like system call, so this was left for the architecture
> maintainers to implement, with __ARCH_WANT_SYS_CLONE3 defined by those
> that already implement it.
>
> Five years later, we still have a few architectures left that are missing
> clone3(), and the macro keeps getting in the way as it's fundamentally
> different from all the other __ARCH_WANT_SYS_* macros that are meant
> to provide backwards-compatibility with applications using older
> syscalls that are no longer provided by default.
>
> Address this by reversing the polarity of the macro, adding an
> __ARCH_BROKEN_SYS_CLONE3 macro to all architectures that don't
> already provide the syscall, and remove __ARCH_WANT_SYS_CLONE3
> from all the other ones.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> arch/m68k/include/asm/unistd.h | 1 -

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds