From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8E6EB64DD for ; Fri, 11 Aug 2023 07:33:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233913AbjHKHd0 (ORCPT ); Fri, 11 Aug 2023 03:33:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233911AbjHKHdZ (ORCPT ); Fri, 11 Aug 2023 03:33:25 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F252312B; Fri, 11 Aug 2023 00:33:23 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 432595C015E; Fri, 11 Aug 2023 03:33:23 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 11 Aug 2023 03:33:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1691739203; x=1691825603; bh=OL 4AYFZyzV0IyAs6oX+QxBd0gaGJ0aoBa9K2dbekbkY=; b=mogk/r/N8yRt7QB9kN nerarNGuigc7ZWP4WZmeGAlA5wFDlMAsJDGjMqb5YqxKKDWpl4gOnGykt6axlq4I rhkzi7cnW1p+lCFTmC26NW6GrQ3hMjNdWk34Sy9yFtomKI2DNlZQ3BYcy5+HXj5L cBEH4cFxKGfFBf2qpSJ0OcVScCnH4gaEfY196SFNFRI6ChwocNlTf5riKunEOzJZ kr8KB84UEgBoD8HFUb7M9iSu+7SX7RdRgM17k4koiKZgZ8pWD1a2D5IwdAKfV9sK xmZEgewXUegev+ljO0pFPZ5fSKrCTf8s3WD1yxCvBjURZO+AdKv5Nsy8cVPphRel HMsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691739203; x=1691825603; bh=OL4AYFZyzV0Iy As6oX+QxBd0gaGJ0aoBa9K2dbekbkY=; b=knkQ54EKuud/lRkoQfZeo0qWOiFzb DI1Ez5BbouSpdayi3z+wmQWR382KJh0saLx9dGNvKgF4nvQ74HH89n9/ZMyECM5l Xd6mNnoBTUSI9mYiBhW0AvE9SKT4Reifbp2Acrels/GYSCLOvdgrAKkqVv5T3tBz HxOEmc5ST/7/EDzXcyqxsAfHkbpusPG26vULV6zWyIqpnhpw3O+tLzZMYB02C5xn AFJPovfLOChpmqJtI9dHFxrLNCLVcUejSuVT+LYkNTbkjhywpwydJwdHXHT4eZCy xwthmElWCQbmKkkPFJ7DOZKgEvpsBvD9Lildl4O/cKDzh0QjLREbC4psA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrleejgdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id C8769B60089; Fri, 11 Aug 2023 03:33:22 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440 Mime-Version: 1.0 Message-Id: In-Reply-To: <20230811030750.1335526-1-guoren@kernel.org> References: <20230811030750.1335526-1-guoren@kernel.org> Date: Fri, 11 Aug 2023 09:32:59 +0200 From: "Arnd Bergmann" To: guoren Cc: "linux-csky@vger.kernel.org" , linux-kernel@vger.kernel.org, Linux-Arch , "Guo Ren" , "Arnd Bergmann" Subject: Re: [PATCH] csky: Fixup -Wmissing-prototypes warning Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Fri, Aug 11, 2023, at 05:07, guoren@kernel.org wrote: > > Link: https://lore.kernel.org/lkml/20230810141947.1236730-17-arnd@kernel.org/ > Reported-by: Arnd Bergmann > Signed-off-by: Guo Ren > Signed-off-by: Guo Ren Thanks for addressing these! Reviewed-by: Arnd Bergmann > --- a/arch/csky/kernel/vdso/vgettimeofday.c > +++ b/arch/csky/kernel/vdso/vgettimeofday.c > @@ -3,24 +3,35 @@ > #include > #include > > +extern > +int __vdso_clock_gettime(clockid_t clock, > + struct old_timespec32 *ts); > int __vdso_clock_gettime(clockid_t clock, > struct old_timespec32 *ts) > { > return __cvdso_clock_gettime32(clock, ts); > } > This works, but it would be a bit nicer to move the declarations into a header. I see that we already handle this in three different ways across x86, arm and arm64, and you picked method from x86 (and loongarch) here, so I can't really complain. What we should probably have instead is a new header in include/vdso/ that declares the functions for every architecture. Arnd