From: Helge Deller <deller@gmx.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Dmitry Osipenko <digetx@gmail.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-m68k@lists.linux-m68k.org,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
"Linux-sh list" <linux-sh@vger.kernel.org>,
xen-devel@lists.xenproject.org,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
"Linux PM" <linux-pm@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Guo Ren" <guoren@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Greg Ungerer" <gerg@linux-m68k.org>,
"Joshua Thompson" <funaho@jurai.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Sebastian Reichel" <sre@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Greentime Hu" <green.hu@gmail.com>,
"Vincent Chen" <deanbo422@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
"Lee Jones" <lee.jones@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
alankao@andestech.com,
"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Subject: Re: [PATCH v6 00/21] Introduce power-off+restart call chain API
Date: Wed, 16 Feb 2022 21:30:26 +0100 [thread overview]
Message-ID: <de2cbd2a-8d0d-8678-e514-b153d04546cc@gmx.de> (raw)
In-Reply-To: <CAJZ5v0g0MrBm2+GwctkB7kUyBEt6HTAexRCFFRmTF1UKDrVQ-g@mail.gmail.com>
On 2/16/22 13:25, Rafael J. Wysocki wrote:
> On Tue, Feb 15, 2022 at 11:00 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> 31.01.2022 02:36, Dmitry Osipenko пишет:
>>> Problem
>>> -------
>>>
>>> SoC devices require power-off call chaining functionality from kernel.
>>> We have a widely used restart chaining provided by restart notifier API,
>>> but nothing for power-off.
>>>
>>> Solution
>>> --------
>>>
>>> Introduce new API that provides both restart and power-off call chains.
>>>
>>> Why combine restart with power-off? Because drivers often do both.
>>> More practical to have API that provides both under the same roof.
>>>
>>> The new API is designed with simplicity and extensibility in mind.
>>> It's built upon the existing restart and reboot APIs. The simplicity
>>> is in new helper functions that are convenient for drivers. The
>>> extensibility is in the design that doesn't hardcode callback
>>> arguments, making easy to add new parameters and remove old.
>>>
>>> This is a third attempt to introduce the new API. First was made by
>>> Guenter Roeck back in 2014, second was made by Thierry Reding in 2017.
>>> In fact the work didn't stop and recently arm_pm_restart() was removed
>>> from v5.14 kernel, which was a part of preparatory work started by
>>> Guenter Roeck. I took into account experience and ideas from the
>>> previous attempts, extended and polished them.
>>
>>
>> Rafael and all, do you see anything critical that needs to be improved
>> in this v6?
>>
>> Will be great if you could take this patchset via the power tree if it
>> looks okay, or give an ack.
>
> I need some more time for this, sorry.
>
> I'm a bit concerned about seeing no response to this set from anyone.
>
> It looks like multiple platforms may be affected by it in principle,
> so doesn't anyone care?
I did looked into the whole patch set after applying it locally.
While I agree a new combined API is good, and the beginning looked promising,
after some time I started to ask myself if the whole infrastructure might
be a little overdesigned.
Anyway, I tested it and it works for me on parisc.
And it's probably better than what we have today.
Helge
next prev parent reply other threads:[~2022-02-16 20:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 23:36 [PATCH v6 00/21] Introduce power-off+restart call chain API Dmitry Osipenko
2022-01-30 23:36 ` [PATCH v6 01/21] notifier: Add blocking_notifier_call_chain_is_empty() Dmitry Osipenko
2022-01-30 23:36 ` [PATCH v6 02/21] notifier: Add atomic/blocking_notifier_chain_register_unique_prio() Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 03/21] reboot: Print error message if restart handler has duplicated priority Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 04/21] kernel: Add combined power-off+restart handler call chain API Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 05/21] ARM: Use do_kernel_power_off() Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 06/21] csky: " Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 07/21] riscv: " Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 08/21] arm64: " Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 09/21] parisc: " Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 10/21] xen/x86: " Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 11/21] powerpc: " Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 12/21] m68k: Switch to new sys-off handler API Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 13/21] sh: Use do_kernel_power_off() Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 14/21] x86: " Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 15/21] ia64: " Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 16/21] mips: " Dmitry Osipenko
2022-02-21 14:42 ` Thomas Bogendoerfer
2022-01-30 23:37 ` [PATCH v6 17/21] nds32: " Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 18/21] memory: emif: Use kernel_can_power_off() Dmitry Osipenko
2022-01-31 9:28 ` Krzysztof Kozlowski
2022-01-30 23:37 ` [PATCH v6 19/21] ACPI: power: Switch to sys-off handler API Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 20/21] regulator: pfuze100: Use devm_register_sys_off_handler() Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 21/21] reboot: Remove pm_power_off_prepare() Dmitry Osipenko
2022-02-15 22:00 ` [PATCH v6 00/21] Introduce power-off+restart call chain API Dmitry Osipenko
2022-02-16 12:25 ` Rafael J. Wysocki
2022-02-16 20:30 ` Helge Deller [this message]
2022-02-17 10:12 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de2cbd2a-8d0d-8678-e514-b153d04546cc@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=alankao@andestech.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=benh@kernel.crashing.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=deanbo422@gmail.com \
--cc=digetx@gmail.com \
--cc=funaho@jurai.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jonathanh@nvidia.com \
--cc=kclin@andestech.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mpe@ellerman.id.au \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulus@samba.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=sre@kernel.org \
--cc=ssantosh@kernel.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).