From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4BC58B6A3 for ; Fri, 11 Sep 2026 19:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789156660; cv=none; b=JcPa9iCmkMsIq4gaAQwRG8yMyhKNRVZFX552PIeJx950BWE+D1zd4uWbzCBHNDsG0xNV9LwxnSrw9LAexJ55TOO1Ku820ceaFD+C1si624crMYwfR22zxy7tMy3I6jt7I4Lchgecf4xhHynmTpUpTyGsAosUjzPJaHcScRral94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789156660; c=relaxed/simple; bh=ayDmY3Z2gd2VthA+m0YcbmO05kekgyCyfICcpFgw0MQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HEtB5fBjyCC7aLE0UhbdvSANyvalZ/Yc2zvAl0Qe1n1Mvc2Vx9Sz4D/sl2msFrYRJsFBgVMVNTf8telooNrHA76v8sZgKxUZr9ScIsFkWUJ80SRufJyR+vGfNqQEiky3oU8uPkq8edy/tLPvwE7UDbsSgBauwlzAWFDYtVw6FgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jkYHeTZT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jkYHeTZT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52ACF1F000FF; Fri, 11 Sep 2026 19:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789156648; bh=JNc+phUVLwViU7D8u8vLS2fZnihwTeUVPlaNqKQ/f6Q=; h=From:To:Cc:Subject:Date:Reply-To; b=jkYHeTZTHJFrPSgoGrmA0/nA2gAB2WASSnco3aRBJ8ejSm4W1QnwAUrDFjXsy8YWL RtjXm6szsPbP0Vqra0pReU/5PaHQRul+BarYZusZ/LArHKieokcRs76UIp+mVCHoo0 4Y1mt+iKdxOSLXetmMw1lZ+kVa6E8sODuvO8xyIg= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2026-89586: ata: libata-scsi: fix DSM TRIM for sector sizes larger than 2048 bytes Date: Fri, 11 Sep 2026 21:44:35 +0200 Message-ID: <2026091129-CVE-2026-89586-d550@gregkh> X-Mailer: git-send-email 2.55.0 Reply-To: , Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3892; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=ouAaPlO+oaXDxon1o6RITBMO3R/wkQxYcTI+bezh8cU=; b=owGbwMvMwCRo6H6F97bub03G02pJDFlLIjNDGbM2aL1WWtUr6tD60rwwavGOnOQFLNH57gxJO r1PXbU7YlkYBJkYZMUUWb5s4zm6v+KQopeh7WmYOaxMIEMYuDgFYCIbrBgWzL+2Tahlv6Uxf5bg FkOXiYmNCy+fZ1hw9leWaMyKL0pua/PLUqUuvWFkXroIAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit From: Greg Kroah-Hartman Description =========== In the Linux kernel, the following vulnerability has been resolved: ata: libata-scsi: fix DSM TRIM for sector sizes larger than 2048 bytes ata_scsi_write_same_xlat() translates a SCSI WRITE SAME command with the UNMAP bit set into an ATA DATA SET MANAGEMENT TRIM command. The TRIM descriptor is built by ata_format_dsm_trim_descr() into the 2048-byte ata_scsi_rbuf staging buffer, and the number of bytes copied is compared against the logical sector size by the caller: size = ata_format_dsm_trim_descr(scmd, trmax, block, n_block); if (size != len) /* len == sdp->sector_size */ goto invalid_param_len; ata_format_dsm_trim_descr() clamps the copy length to ATA_SCSI_RBUF_SIZE (2048). On a device whose logical sector size exceeds that (e.g. a 4Kn device, where sector_size == 4096) the function can never return more than 2048, while the caller expects it to return sector_size. The comparison therefore always fails, so every TRIM is rejected with "Parameter list length error" and WARN_ON() splats on each attempt. TRIM / discard is thus completely broken on such devices. The descriptor was incorrectly sized from the logical sector size. A DSM TRIM payload is a list of 512-byte pages, each holding up to ATA_MAX_TRIM_RNUM (64) LBA Range Entries, and is independent of the logical sector size. The Block Limits VPD page already advertises a single such page as the maximum WRITE SAME length (65535 * ATA_MAX_TRIM_RNUM logical blocks), so the block layer never sends a request that needs more than one page. Emit exactly one 512-byte page, independent of the logical sector size, and transfer only that page (COUNT == 1). For a 512-byte-sector device this is unchanged; devices with larger logical sectors now work instead of failing every TRIM. The Linux kernel CVE team has assigned CVE-2026-89586 to this issue. Affected and fixed versions =========================== Issue introduced in 4.9 with commit ef2d7392c4ece5c3cd12a6c7ca9366cd8f189aff and fixed in 6.12.109 with commit 04e2befe25792f2e90097f284d7e86fc6bcfe928 Issue introduced in 4.9 with commit ef2d7392c4ece5c3cd12a6c7ca9366cd8f189aff and fixed in 6.18.50 with commit c2e3dccd6870659851eaa4c12ab16418b8e3040a Issue introduced in 4.9 with commit ef2d7392c4ece5c3cd12a6c7ca9366cd8f189aff and fixed in 7.2.4 with commit 4a4268a0b0a595bd9534cf9c7fda93775a7d8a0d Issue introduced in 4.9 with commit ef2d7392c4ece5c3cd12a6c7ca9366cd8f189aff and fixed in 7.3-rc1 with commit 79cce911e623c0baa0fde307ce3a434e084b881a Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2026-89586 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/ata/libata-scsi.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/04e2befe25792f2e90097f284d7e86fc6bcfe928 https://git.kernel.org/stable/c/c2e3dccd6870659851eaa4c12ab16418b8e3040a https://git.kernel.org/stable/c/4a4268a0b0a595bd9534cf9c7fda93775a7d8a0d https://git.kernel.org/stable/c/79cce911e623c0baa0fde307ce3a434e084b881a