CVE-2026-89624: HID: universal-pidff: stop the device when force-feedback init fails

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

From: Greg Kroah-Hartman <gregkh@kernel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

HID: universal-pidff: stop the device when force-feedback init fails

universal_pidff_probe() starts the device with hid_hw_start() and then, if
force-feedback initialisation fails, returns the error through a label that
only does "return error".  The device is left started.

The HID core does not unwind on the driver's behalf.  __hid_device_probe()
releases the devres group, closes the report and clears hdev->driver:

	if (ret) {
		devres_release_group(&hdev->dev, hdev->devres_group_id);
		hid_close_report(hdev);
		hdev->driver = NULL;
	}

The hidraw character device that hid_hw_start() registered through
hid_connect() is allocated with kzalloc() and added with cdev_device_add(),
so it is not devres-managed and survives that.  With hdev->driver NULL,
hid_device_remove() skips hid_hw_stop() as well, because it only unwinds
while a driver is still attached.  The registration therefore outlives the
device on both paths.

Opening the surviving /dev/hidrawX writes into freed memory.  KASAN reports
a use-after-free write from hidraw_open() -> hid_hw_open() -> the
transport's open callback, which takes a spinlock inside the freed object.
A descriptor that carries a PID usage page and no input reports is enough:
hidraw claims the device so hid_hw_start() succeeds, while hid->inputs
stays empty so force-feedback init fails.  The other failure returns in
hid_pidff_init_with_quirks() - no output reports, an allocation failure,
pidff_init_fields(), pidff_check_autocenter(), an unusable effect count,
input_ff_create() - all reach the same label.

Stop the device on that path.  hid-dr.c and hid-emsff.c, which start the
device with the same HID_CONNECT_DEFAULT & ~HID_CONNECT_FF mask, already do
this.  The two earlier gotos must keep returning without hid_hw_stop(),
since neither has a started device, so give the path that fails after the
start its own label.

Discovered by XBOW, triaged by Baul Lee <baul.lee@xbow.com>

The Linux kernel CVE team has assigned CVE-2026-89624 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 6.15 with commit f06bf8d94fffbb544b1cb5402c92e0a075f0d420 and fixed in 6.18.50 with commit 01d9874e84d3ab78fd212ad822412eb3af84497f
	Issue introduced in 6.15 with commit f06bf8d94fffbb544b1cb5402c92e0a075f0d420 and fixed in 7.2.4 with commit c457bb516b61edeab940235a011928e26925381e
	Issue introduced in 6.15 with commit f06bf8d94fffbb544b1cb5402c92e0a075f0d420 and fixed in 7.3-rc1 with commit ce08c5555cabcd444d8b77fa69a7cb68bb05f611
	Issue introduced in 6.6.88 with commit c1fde337b317f0a226de92803288741c30799eb0
	Issue introduced in 6.12.24 with commit f45f26a6b3e7260c129c7c6bb0ace63aeb7b3868
	Issue introduced in 6.13.12 with commit af9f2471dfe5a48384f5b7f021a673fbc741465e
	Issue introduced in 6.14.3 with commit b797352954eee6dc084cfaed0659dea60adfb484

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2026-89624
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/hid/hid-universal-pidff.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/01d9874e84d3ab78fd212ad822412eb3af84497f
	https://git.kernel.org/stable/c/c457bb516b61edeab940235a011928e26925381e
	https://git.kernel.org/stable/c/ce08c5555cabcd444d8b77fa69a7cb68bb05f611