Re: [PATCH] cxl/acpi: Warn about an invalid CHBCR in an existing CHBS entry

[Dave Jiang <dave.jiang@intel.com>]

On 12/5/2022 1:21 PM, Dan Williams wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> After parsing for a CHBCR in cxl_get_chbcr() the case of (ctx.chbcr ==
> CXL_RESOURCE_NONE) is a slighly different error reason than the
> !ctx.chbcr case. In the first case the CHBS was found but the CHBCR
> was invalid or something else failed to determine it, while in the
> latter case no CHBS entry exists at all.
> 
> Update the warning message to reflect this. The log messages for both
> cases can be differentiated now and the reason for a failure can be
> determined better.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>   drivers/cxl/acpi.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index 420e322c85a1..f495f3ce45d1 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -455,7 +455,8 @@ static int add_host_bridge_dport(struct device *match, void *arg)
>   		dev_dbg(match, "RCRB found for UID %lld: %pa\n", uid, &ctx.rcrb);
>   
>   	if (ctx.chbcr == CXL_RESOURCE_NONE) {
> -		dev_warn(match, "No CHBS found for Host Bridge (UID %lld)\n", uid);
> +		dev_warn(match, "CHBCR invalid for Host Bridge (UID %lld)\n",
> +			 uid);
>   		return 0;
>   	}
>   
>