From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"a.manzanares@samsung.com" <a.manzanares@samsung.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH] cxl/monitor: Make libtracefs dependency optional
Date: Fri, 24 Feb 2023 00:18:35 +0000 [thread overview]
Message-ID: <0daf23ea2d52bfebbaaae76f461dd8566df4961d.camel@intel.com> (raw)
In-Reply-To: <20230223232817.GA469785@bgt-140510-bm01>
On Thu, 2023-02-23 at 23:28 +0000, Adam Manzanares wrote:
> On Thu, Feb 23, 2023 at 12:29:02PM -0800, Dan Williams wrote:
> > Build a stub version of 'cxl monitor' that reports that the facility was
> > statically disabled at configure / build time. Provide the meson
> > configuration line to correct the build.
> >
> > This is in response to the fact that some distros fail to ship
> > libtracefs-devel even though they ship libtracefs (looking at you CentOS
> > Stream 8).
> >
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > ---
> > config.h.meson | 3 +++
> > cxl/builtin.h | 9 +++++++++
> > cxl/meson.build | 33 +++++++++++++++++++++------------
> > meson.build | 7 +++++--
> > meson_options.txt | 1 +
> > ndctl.spec.in | 8 +++++---
> > 6 files changed, 44 insertions(+), 17 deletions(-)
>
<..>
> Heads up, I just built ndctl devel branch on tumbleweed and libtracefs-dev
> puts include files in libtracefs/tracefs.h
Yep this was reported earlier today:
https://github.com/pmem/ndctl/issues/234
I'll have a fix and a 76.1 release with these shortly!
next prev parent reply other threads:[~2023-02-24 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230223232827uscas1p20e3b2e7f942b1672d951a2b2cf4ffbc2@uscas1p2.samsung.com>
2023-02-23 20:29 ` [ndctl PATCH] cxl/monitor: Make libtracefs dependency optional Dan Williams
2023-02-23 23:28 ` Adam Manzanares
2023-02-24 0:18 ` Verma, Vishal L [this message]
2023-02-24 8:04 ` Ira Weiny
2023-02-24 15:27 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0daf23ea2d52bfebbaaae76f461dd8566df4961d.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=a.manzanares@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox