On 19/11/25 01:44PM, Dave Jiang wrote: > > >On 11/19/25 12:52 AM, Neeraj Kumar wrote: >> In 84ec985944ef3, devm_cxl_add_nvdimm() sequence was changed and called >> before devm_cxl_add_endpoint(). It's because cxl pmem region auto-assembly >> used to get called at last in cxl_endpoint_port_probe(), which requires >> cxl_nvd presence. >> >> For cxl region persistency, region creation happens during nvdimm_probe >> which need the completion of endpoint probe. >> >> In order to accommodate both cxl pmem region auto-assembly and cxl region >> persistency, refactored following >> >> 1. Re-Sequence devm_cxl_add_nvdimm() after devm_cxl_add_endpoint(). This >> will be called only after successful completion of endpoint probe. >> >> 2. Create cxl_region_discovery() which performs pmem region >> auto-assembly and remove cxl pmem region auto-assembly from >> cxl_endpoint_port_probe() >> >> 3. Register cxl_region_discovery() with devm_cxl_add_memdev() which gets >> called during cxl_pci_probe() in context of cxl_mem_probe() >> >> 4. As cxlmd->ops->probe() calls registered cxl_region_discovery(), so >> move devm_cxl_add_nvdimm() before cxlmd->ops->probe(). It gurantees > >s/gurantees/guarantees/ Fixed it in V5 > >> both the completion of endpoint probe and cxl_nvd presence before >> calling cxlmd->ops->probe(). >> >> Signed-off-by: Neeraj Kumar > >Reviewed-by: Dave Jiang Thanks Dave for RB tag Regards, Neeraj