From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BE3E1DDC2C for ; Mon, 2 Jun 2025 10:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748860311; cv=none; b=Q0vSYHBqRoKhatQ7JQCPbepyp6SeFy/e6ibckJpcMCcI72GdAxZEQZuYGVOkU3IF1UK0dXZnpaL+70FsGjrJuff/xk2BWlWCvRy2sepg+uD5zLVln+dKkvS+wy4mwMudmTteLG7qaC601F/xclndK97TUyjG95cwjZndtzbm3xQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748860311; c=relaxed/simple; bh=ZzssR7Z3WXTPxuV3RaTrvsQITalfSEGHtp9paP/nu3A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jsTjzKhjG6Gqo14GTmpWx9yEv0rSFQwcd2obgLNBYL5+5kiCRNX30sNu5BVbpPYi7U8bbqjfI9c9Ht8oMcd28HfdzNgkYFheChHNKsIAilOS3AojTxCf2/K9sBG0k3mCYJwanhVhZqQClhNUybz+lZ1HbyQB28Apipy+vXrPbxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BIqhjEgc; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BIqhjEgc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748860308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zNGcx2ArrxJr8cIK8d0qYe5Yw20pPHTlFAddIJE8YQE=; b=BIqhjEgcyXhzr5YECzxep8f2NgNI8G81kTty+Kc/cu15MbXjk00H3FdW3F9zjm1Rip1Y1X 8teCHTL40WAdivR3ENG4a+fd1i+K4l/15xobcNpWvwx80tpFtbSQfKBiEExT+FxK7SN/8x UzhdAGOzSx+Sa3aISKC+LRJcZSkSGe4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-OFC3G--jOY6iajJSAH6ATg-1; Mon, 02 Jun 2025 06:31:47 -0400 X-MC-Unique: OFC3G--jOY6iajJSAH6ATg-1 X-Mimecast-MFC-AGG-ID: OFC3G--jOY6iajJSAH6ATg_1748860306 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-440667e7f92so29217635e9.3 for ; Mon, 02 Jun 2025 03:31:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748860306; x=1749465106; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zNGcx2ArrxJr8cIK8d0qYe5Yw20pPHTlFAddIJE8YQE=; b=rOH5Tr0s83kEMiGyNgQ1Muh+jF5VeQx/pvoUjY2KXQclvTQCLYdaWOoWtNisUEweya +hei3tV4rGpV3XwwHYT5LGExIgNJ6sUGDv+aO0AbAT7R4aE1oRqr6nvGSUVUL6Za3pZm IG0XUIhfZdZH1e2J594Us+UPvLjcboJg1puYpsgG4sYuR2m9e+Z6VlmiqpoawoZGrmoa ADt+epNgEAtGsi3DLAxgN8QtQ9ESA9yGPk41RzgK5vLUDPDS4/eD9kupPzFwbDZDGan3 YvJCGL3Pr0C4xURlA45tOtfY8BxEyIhCJdPrR1KSPCaFziDckS3ivuu/M1EFRcZYSN1p xbVA== X-Forwarded-Encrypted: i=1; AJvYcCX0Vb8eqoh965ZZAF41Q5BIEzE9rZUh1cSTYOha84Db6LDhd3KsHNKld1toJ6rgukSE+itTaook69c=@vger.kernel.org X-Gm-Message-State: AOJu0YzOVdk8pWjlQ0mZ7SqOY89Z9cvHZWHsi5SZkSU772dTh80ngC8O BTj7uTXp7hmBXfhw10OA5bPhQ/2+R7qTOaNs0ZOYFCtkOOfub3tYlLWCKMdkv5+PNgtJHXHPi2G WuYUGjBA9K+d0OHihDK9ZA05Xk/XtyYrxDeJAsg/qRVPnkaiXlJWJ1qrT99+9fg== X-Gm-Gg: ASbGncvxHdPNvoCB4iSgoMWS4oHi9QGpU55bWBo0693PoDvm36EjxatsldwKcKYOM2/ Xj3YVDrC2q70hq4YbehDZtHjHIWUbPfOQTJKwEiXFNtfQnd9gJVzjibwVfV7okJlbnwivtveRik WdxC4XiQWCOuFXK2u7D14TiUdiJMGIByKc5ej+Ew95RKKL+iou8QfS2jkHytjrYSyaAcBy+29DG 5r/faaIWM0Sw1heTLLJV/NkGunLjk6e8VDM0xVBqI9bXe9WI3Ky3S4lT1pvs7o1A/i8UXtu8X+G 7IxviNyqoDkGk3b8M7zESyASgB3+eVD3GIfkrRUDw7a6zYgHTd72kbiZa1oPzQGXAnXuLCp2acL 1KGk44XvzMll/HR2dGFehX2z+CsEJxCthGluuHK0= X-Received: by 2002:a05:600c:4e48:b0:443:48:66d2 with SMTP id 5b1f17b1804b1-4511ee14c08mr77083295e9.16.1748860305798; Mon, 02 Jun 2025 03:31:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4lrvLwHaEWScY/8IOL/Tuots8CWM7YWfHJfcP7R1yvYuRofYdh+DhIzzTEbvoU5wPzbYr8A== X-Received: by 2002:a05:600c:4e48:b0:443:48:66d2 with SMTP id 5b1f17b1804b1-4511ee14c08mr77082755e9.16.1748860305291; Mon, 02 Jun 2025 03:31:45 -0700 (PDT) Received: from ?IPV6:2003:d8:2f34:a300:1c2c:f35e:e8e5:488e? (p200300d82f34a3001c2cf35ee8e5488e.dip0.t-ipconnect.de. [2003:d8:2f34:a300:1c2c:f35e:e8e5:488e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7f8f1e7sm118287075e9.1.2025.06.02.03.31.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jun 2025 03:31:44 -0700 (PDT) Message-ID: <13ea6653-d33d-4f76-88c8-a17f9989d069@redhat.com> Date: Mon, 2 Jun 2025 12:31:43 +0200 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/12] mm: Remove pXX_devmap page table bit and pfn_t type To: Alistair Popple , linux-mm@kvack.org Cc: gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, jgg@ziepe.ca, willy@infradead.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@Groves.net References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TceinUKiai-XFTTWi5p-qKyv6YY6gqdvBpqXaQ0r5Lo_1748860306 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29.05.25 08:32, Alistair Popple wrote: > Changes from v2 of the RFC[1]: > > - My ZONE_DEVICE refcount series has been merged as commit 7851bf649d42 (Patch series > "fs/dax: Fix ZONE_DEVICE page reference counts", v9.) which is included in > v6.15 so have rebased on top of that. > > - No major changes required for the rebase other than fixing up a new user of > the pfn_t type (intel_th). > > - As a reminder the main benefit of this series is it frees up a PTE bit > (pte_devmap). > > - This may be a bit late to consider for inclusion in v6.16 unless it can get > some more reviews before the merge window closes. I don't think missing v6.16 > is a huge issue though. > > - This passed xfstests for a XFS filesystem with DAX enabled on my system and > as many of the ndctl tests that pass on my system without it. > > Changes for v2: > > - This is an update to my previous RFC[2] removing just pfn_t rebased > on today's mm-unstable which includes my ZONE_DEVICE refcounting > clean-up. > > - The removal of the devmap PTE bit and associated infrastructure was > dropped from that series so I have rolled it into this series. > > - Logically this series makes sense to me, but the dropping of devmap > is wide ranging and touches some areas I'm less familiar with so > would definitely appreciate any review comments there. > > [1] - https://lore.kernel.org/linux-mm/cover.95ff0627bc727f2bae44bea4c00ad7a83fbbcfac.1739941374.git-series.apopple@nvidia.com/ > [2] - https://lore.kernel.org/linux-mm/cover.a7cdeffaaa366a10c65e2e7544285059cc5d55a4.1736299058.git-series.apopple@nvidia.com/ > > All users of dax now require a ZONE_DEVICE page which is properly > refcounted. This means there is no longer any need for the PFN_DEV, PFN_MAP > and PFN_SPECIAL flags. Furthermore the PFN_SG_CHAIN and PFN_SG_LAST flags > never appear to have been used. It is therefore possible to remove the > pfn_t type and replace any usage with raw pfns. > > The remaining users of PFN_DEV have simply passed this to > vmf_insert_mixed() to create pte_devmap() mappings. It is unclear why this > was the case but presumably to ensure vm_normal_page() does not return > these pages. These users can be trivially converted to raw pfns and > creating a pXX_special() mapping to ensure vm_normal_page() still doesn't > return these pages. > > Now that there are no users of PFN_DEV we can remove the devmap page table > bit and all associated functions and macros, freeing up a software page > table bit. > $ git grep FS_DAX_LIMITED fs/Kconfig: depends on ZONE_DEVICE || FS_DAX_LIMITED fs/Kconfig:config FS_DAX_LIMITED fs/dax.c: if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) fs/dax.c: if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) fs/dax.c: if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) include/linux/pfn_t.h: * PFN_SPECIAL - for CONFIG_FS_DAX_LIMITED builds to allow XIP, but not mm/memremap.c: if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { Can we remove that? Especially the interaction with PFN_SPECIAL looks concerning. -- Cheers, David / dhildenb