From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6F74242D99 for ; Mon, 6 Oct 2025 04:53:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759726392; cv=none; b=RvvuC12ht8+sq/XsqfKZg5nLCVnqQY1AYj15Kpw2fv2ECiTjxe/cfJSlG92L/x1weqj1Niz9jB60fSnlJjctO2ctB/uKhcK8qbm5rO1J8me3rfrW1XcYKbYIbcoeK4BE1/vpwzU7Swsa06okwGLks0SNoFJNssivIDdyCe74hY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759726392; c=relaxed/simple; bh=uR75BCVZ6r3o8n2JHxZklEM0P6Tcd4w6w+UH3FP2RqA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:In-Reply-To: Content-Type:References; b=BkcjRXC14PhWTmYWtkk/jhZ6VxvKGnhgqv0cgQjfHH+sqYTIjJahwc8TE+wIVZ77utc/jOQuOZBUo6DgF2CMu2f2tXV2BML1UiYKX2M/nh8BTB+hdSR2efj+lUlXMY3eotSX7UoCz9dQ8UjSqEBcMJcBwh94IlEmUDn0hP8Dbvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=t7X9oniF; arc=none smtp.client-ip=203.254.224.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="t7X9oniF" Received: from epcas5p1.samsung.com (unknown [182.195.41.39]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20251006045303epoutp031c8bab5e70269b4b020902a360e2bd04~rzdJwxFYF1644916449epoutp03E for ; Mon, 6 Oct 2025 04:53:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20251006045303epoutp031c8bab5e70269b4b020902a360e2bd04~rzdJwxFYF1644916449epoutp03E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1759726383; bh=7SziAcs69Ob1GmYme5dJMaRr/WnjrJV6VSEynsS+bZg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t7X9oniFwMi5TC++Kr658co1gcnzX0fR4VyyNC/k8gDdMeJPOrL+C9UqmxxNvzCqW hbN+IUWIHzv33naptPVGGymLxfEDZv+vDjttBjRBwlTwXMOrAinZ0+PjBVs3ZIO9EJ 8mak3RlEt8H6OHf8kWVi3IZRulcbKX8+8pgFBDwk= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPS id 20251006045302epcas5p36d894bd40f35a1a4aa5ddfdca08738ee~rzdJDaZNM0317603176epcas5p3b; Mon, 6 Oct 2025 04:53:02 +0000 (GMT) Received: from epcpadp2new (unknown [182.195.40.142]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4cg6My2Rbkz3hhT3; Mon, 6 Oct 2025 04:53:02 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPA id 20250929132629epcas5p4f44fae4e2e0bcde47b7bd185582494d2~pw8czcfQR2147921479epcas5p4s; Mon, 29 Sep 2025 13:26:29 +0000 (GMT) Received: from test-PowerEdge-R740xd (unknown [107.99.41.79]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250929132627epsmtip1a7bc6a34c233be2b6d8723843c4d541b~pw8a7SUoc2638126381epsmtip1T; Mon, 29 Sep 2025 13:26:27 +0000 (GMT) Date: Mon, 29 Sep 2025 18:56:22 +0530 From: Neeraj Kumar To: Dave Jiang Cc: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, gost.dev@samsung.com, a.manzanares@samsung.com, vishak.g@samsung.com, neeraj.kernel@gmail.com, cpgs@samsung.com Subject: Re: [PATCH V3 12/20] nvdimm/region_label: Export routine to fetch region information Message-ID: <158453976.61759726382339.JavaMail.epsvc@epcpadp2new> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-CMS-MailID: 20250929132629epcas5p4f44fae4e2e0bcde47b7bd185582494d2 X-Msg-Generator: CA Content-Type: multipart/mixed; boundary="----xsJXu.fD5V5xDhddWNWtQINaZQo.kzBR_hLvg.7oVeVxw7Lp=_733d_" CMS-TYPE: 105P X-CPGSPASS: Y X-Hop-Count: 3 X-CMS-RootMailID: 20250917134153epcas5p1e1f7a7a19fb41d12b9397c3e6265f823 References: <20250917134116.1623730-1-s.neeraj@samsung.com> <20250917134116.1623730-13-s.neeraj@samsung.com> ------xsJXu.fD5V5xDhddWNWtQINaZQo.kzBR_hLvg.7oVeVxw7Lp=_733d_ Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Disposition: inline On 23/09/25 01:23PM, Dave Jiang wrote: > > >On 9/17/25 6:41 AM, Neeraj Kumar wrote: >> +bool nvdimm_has_cxl_region(struct nvdimm *nvdimm) >> +{ >> + if (nvdimm) >> + return nvdimm->is_region_label; >> + >> + return false; > >Just a nit. Would prefer return error early and return the success case last. > >> +} >> +EXPORT_SYMBOL_GPL(nvdimm_has_cxl_region); >> + >> +void *nvdimm_get_cxl_region_param(struct nvdimm *nvdimm) >> +{ >> + if (nvdimm) >> + return &nvdimm->cxl_region_params; >> + >> + return NULL; > >same comment > Sure Dave, Will fix it accordingly Regards, Neeraj ------xsJXu.fD5V5xDhddWNWtQINaZQo.kzBR_hLvg.7oVeVxw7Lp=_733d_ Content-Type: text/plain; charset="utf-8" ------xsJXu.fD5V5xDhddWNWtQINaZQo.kzBR_hLvg.7oVeVxw7Lp=_733d_--