Re: [RFC PATCH 01/20] nvdimm/label: Introduce NDD_CXL_LABEL flag to set cxl label format

[Neeraj Kumar <s.neeraj@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

On 02/07/25 01:02PM, Ira Weiny wrote:
>Neeraj Kumar wrote:
>> NDD_CXL_LABEL is introduced to set cxl LSA 2.1 label format
>> Accordingly updated label index version
>
>I'm not following why CXL specific code needs to be in nvdimm?

Hi Ira,

Prior to LSA 2.1 version, LSA contain only namespace labels. LSA 2.1 was
introduced in CXL 2.0 Spec, which introduced region label along with
namespace label.

NDD_LABELING is the flag used to inform nvdimm driver about namespace
labels. As region label was introduced in cxl spec. so, I have used
NDD_CXL_LABEL flag to inform nvdimmm driver about it.

I have taken this naming reference from "drivers/nvdimm/label.h"
where region label is defined as "struct cxl_region_label"

Please let me know if i should use some other name in place of this


>
>I did not get a cover letter in this thread and looking at lore I don't
>see one either:
>
>https://lore.kernel.org/all/158453976.61750165203630.JavaMail.epsvc@epcpadp1new/
>
>So perhaps I am completely out of the loop here?  Could you point me at a
>cover letter?

Yes, there seems some issue due to which my patch thread got broken into two.
1. Cover letter:
https://lore.kernel.org/linux-cxl/1931444790.41750165203442.JavaMail.epsvc@epcpadp1new/

2. Rest of the thread:
https://lore.kernel.org/linux-cxl/158453976.61750165203630.JavaMail.epsvc@epcpadp1new/


Regards,
Neeraj

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]