Re: [PATCH 03/14] cxl/mem: Find device capabilities

David Rientjes
2021-02-02T01:10:19Z

On Mon, 1 Feb 2021, Dan Williams wrote:

> > > I don't have an objection to binding, but doesn't this require that the
> > > check in cxl_validate_cmd_from_user() guarantees send_cmd->size_in cannot
> > > be greater than 1MB?
> >
> > You're correct. I'd need to add:
> > cxlm->mbox.payload_size =
> > min_t(size_t, 1 << CXL_GET_FIELD(cap, CXLDEV_MB_CAP_PAYLOAD_SIZE), 1<<20)
>
> nit, use the existing SZ_1M define.
>

Sounds good, thanks both! I'll assume you'll follow-up on this in the
next revision for patch 7 ("cxl/mem: Add send command") and we can
consider this resolved :)