From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91024C4338F for ; Wed, 11 Aug 2021 18:47:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 484226101D for ; Wed, 11 Aug 2021 18:47:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbhHKSr1 (ORCPT ); Wed, 11 Aug 2021 14:47:27 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3638 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbhHKSr1 (ORCPT ); Wed, 11 Aug 2021 14:47:27 -0400 Received: from fraeml742-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GlJgh3VwSz6GDpl; Thu, 12 Aug 2021 02:46:24 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml742-chm.china.huawei.com (10.206.15.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 11 Aug 2021 20:47:01 +0200 Received: from localhost (10.52.123.85) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 11 Aug 2021 19:47:01 +0100 Date: Wed, 11 Aug 2021 19:46:30 +0100 From: Jonathan Cameron To: Dan Williams CC: , , , , , Subject: Re: [PATCH 08/23] libnvdimm/labels: Add claim class helpers Message-ID: <20210811194630.000020bc@Huawei.com> In-Reply-To: <162854811000.1980150.8798912622256692357.stgit@dwillia2-desk3.amr.corp.intel.com> References: <162854806653.1980150.3354618413963083778.stgit@dwillia2-desk3.amr.corp.intel.com> <162854811000.1980150.8798912622256692357.stgit@dwillia2-desk3.amr.corp.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.123.85] X-ClientProxiedBy: lhreml716-chm.china.huawei.com (10.201.108.67) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Mon, 9 Aug 2021 15:28:30 -0700 Dan Williams wrote: > In preparation for LIBNVDIMM to manage labels on CXL devices deploy > helpers that abstract the label type from the implementation. The CXL > label format is mostly similar to the EFI label format with concepts / > fields added, like dynamic region creation and label type guids, and > other concepts removed like BLK-mode and interleave-set-cookie ids. > > CXL labels do have the concept of a claim class represented by an > "abstraction" identifier. It turns out both label implementations use > the same ids, but EFI encodes them as GUIDs and CXL labels encode them > as UUIDs. For now abstract out the claim class such that the UUID vs > GUID distinction can later be hidden in the helper. > > Signed-off-by: Dan Williams Reviewed-by: Jonathan Cameron > --- > drivers/nvdimm/label.c | 31 ++++++++++++++++++++++--------- > drivers/nvdimm/label.h | 1 - > drivers/nvdimm/namespace_devs.c | 13 ++++--------- > drivers/nvdimm/nd.h | 2 ++ > 4 files changed, 28 insertions(+), 19 deletions(-) > > diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c > index 294ffc3cb582..7f473f9db300 100644 > --- a/drivers/nvdimm/label.c > +++ b/drivers/nvdimm/label.c > @@ -724,7 +724,7 @@ static unsigned long nd_label_offset(struct nvdimm_drvdata *ndd, > - (unsigned long) to_namespace_index(ndd, 0); > } > > -enum nvdimm_claim_class to_nvdimm_cclass(guid_t *guid) > +static enum nvdimm_claim_class to_nvdimm_cclass(guid_t *guid) > { > if (guid_equal(guid, &nvdimm_btt_guid)) > return NVDIMM_CCLASS_BTT; > @@ -792,6 +792,25 @@ bool nsl_validate_type_guid(struct nvdimm_drvdata *ndd, > return true; > } > > +static void nsl_set_claim_class(struct nvdimm_drvdata *ndd, > + struct nd_namespace_label *nd_label, > + enum nvdimm_claim_class claim_class) > +{ > + if (!namespace_label_has(ndd, abstraction_guid)) > + return; > + guid_copy(&nd_label->abstraction_guid, > + to_abstraction_guid(claim_class, > + &nd_label->abstraction_guid)); > +} > + > +enum nvdimm_claim_class nsl_get_claim_class(struct nvdimm_drvdata *ndd, > + struct nd_namespace_label *nd_label) > +{ > + if (!namespace_label_has(ndd, abstraction_guid)) > + return NVDIMM_CCLASS_NONE; > + return to_nvdimm_cclass(&nd_label->abstraction_guid); > +} > + > static int __pmem_label_update(struct nd_region *nd_region, > struct nd_mapping *nd_mapping, struct nd_namespace_pmem *nspm, > int pos, unsigned long flags) > @@ -843,10 +862,7 @@ static int __pmem_label_update(struct nd_region *nd_region, > nsl_set_dpa(ndd, nd_label, res->start); > nsl_set_slot(ndd, nd_label, slot); > nsl_set_type_guid(ndd, nd_label, &nd_set->type_guid); > - if (namespace_label_has(ndd, abstraction_guid)) > - guid_copy(&nd_label->abstraction_guid, > - to_abstraction_guid(ndns->claim_class, > - &nd_label->abstraction_guid)); > + nsl_set_claim_class(ndd, nd_label, ndns->claim_class); > nsl_calculate_checksum(ndd, nd_label); > nd_dbg_dpa(nd_region, ndd, res, "\n"); > > @@ -1111,10 +1127,7 @@ static int __blk_label_update(struct nd_region *nd_region, > nsl_set_lbasize(ndd, nd_label, nsblk->lbasize); > nsl_set_slot(ndd, nd_label, slot); > nsl_set_type_guid(ndd, nd_label, &nd_set->type_guid); > - if (namespace_label_has(ndd, abstraction_guid)) > - guid_copy(&nd_label->abstraction_guid, > - to_abstraction_guid(ndns->claim_class, > - &nd_label->abstraction_guid)); > + nsl_set_claim_class(ndd, nd_label, ndns->claim_class); > nsl_calculate_checksum(ndd, nd_label); > > /* update label */ > diff --git a/drivers/nvdimm/label.h b/drivers/nvdimm/label.h > index 956b6d1bd8cc..31f94fad7b92 100644 > --- a/drivers/nvdimm/label.h > +++ b/drivers/nvdimm/label.h > @@ -135,7 +135,6 @@ struct nd_namespace_label *nd_label_active(struct nvdimm_drvdata *ndd, int n); > u32 nd_label_alloc_slot(struct nvdimm_drvdata *ndd); > bool nd_label_free_slot(struct nvdimm_drvdata *ndd, u32 slot); > u32 nd_label_nfree(struct nvdimm_drvdata *ndd); > -enum nvdimm_claim_class to_nvdimm_cclass(guid_t *guid); > struct nd_region; > struct nd_namespace_pmem; > struct nd_namespace_blk; > diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c > index af5a31dd3147..58c76d74127a 100644 > --- a/drivers/nvdimm/namespace_devs.c > +++ b/drivers/nvdimm/namespace_devs.c > @@ -2042,10 +2042,8 @@ static struct device *create_namespace_pmem(struct nd_region *nd_region, > nspm->uuid = kmemdup((void __force *) label0->uuid, > NSLABEL_UUID_LEN, GFP_KERNEL); > nspm->lbasize = nsl_get_lbasize(ndd, label0); > - if (namespace_label_has(ndd, abstraction_guid)) > - nspm->nsio.common.claim_class > - = to_nvdimm_cclass(&label0->abstraction_guid); > - > + nspm->nsio.common.claim_class = > + nsl_get_claim_class(ndd, label0); > } > > if (!nspm->alt_name || !nspm->uuid) { > @@ -2273,11 +2271,8 @@ static struct device *create_namespace_blk(struct nd_region *nd_region, > dev->parent = &nd_region->dev; > nsblk->id = -1; > nsblk->lbasize = nsl_get_lbasize(ndd, nd_label); > - nsblk->uuid = kmemdup(nd_label->uuid, NSLABEL_UUID_LEN, > - GFP_KERNEL); > - if (namespace_label_has(ndd, abstraction_guid)) > - nsblk->common.claim_class > - = to_nvdimm_cclass(&nd_label->abstraction_guid); > + nsblk->uuid = kmemdup(nd_label->uuid, NSLABEL_UUID_LEN, GFP_KERNEL); > + nsblk->common.claim_class = nsl_get_claim_class(ndd, nd_label); > if (!nsblk->uuid) > goto blk_err; > nsl_get_name(ndd, nd_label, name); > diff --git a/drivers/nvdimm/nd.h b/drivers/nvdimm/nd.h > index f3c364df9449..ac80d9680367 100644 > --- a/drivers/nvdimm/nd.h > +++ b/drivers/nvdimm/nd.h > @@ -181,6 +181,8 @@ bool nsl_validate_blk_isetcookie(struct nvdimm_drvdata *ndd, > u64 isetcookie); > bool nsl_validate_type_guid(struct nvdimm_drvdata *ndd, > struct nd_namespace_label *nd_label, guid_t *guid); > +enum nvdimm_claim_class nsl_get_claim_class(struct nvdimm_drvdata *ndd, > + struct nd_namespace_label *nd_label); > > struct nd_region_data { > int ns_count; >