From: Ben Widawsky <ben.widawsky@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-cxl@vger.kernel.org,
Alison Schofield <alison.schofield@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH 3/3] cxl/docs: Remove undocumented references
Date: Thu, 2 Sep 2021 10:09:33 -0700 [thread overview]
Message-ID: <20210902170933.emi4justeyel5elf@intel.com> (raw)
In-Reply-To: <CAPcyv4iA9CywmxsT9GbOVhNcpdM1Bc4XNe69FuPLFiTuQvL+HQ@mail.gmail.com>
On 21-09-01 12:18:59, Dan Williams wrote:
> On Mon, Aug 30, 2021 at 10:17 AM Ben Widawsky <ben.widawsky@intel.com> wrote:
> >
> > When the core pmem and regs implementation was added, there were no
> > structured comments added. This change allows docs to be generated
> > without warnings.
> >
>
> Hmm, might be better to go the other and fix this with patches to add
> documentation. At least devm_cxl_add_nvdimm_bridge() would benefit and
> regs.c has some kernel-doc annotations, just needs the header section
> added.
That'd be my preference, but I'll leave that to you if that's okay.
next prev parent reply other threads:[~2021-09-02 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 17:17 [PATCH 1/3] cxl: Fixed defined but not used warnings Ben Widawsky
2021-08-30 17:17 ` [PATCH 2/3] cxl/core/mbox: Remove extra parameter docs Ben Widawsky
2021-09-01 19:15 ` Dan Williams
2021-09-04 0:39 ` Dan Williams
2021-08-30 17:17 ` [PATCH 3/3] cxl/docs: Remove undocumented references Ben Widawsky
2021-09-01 19:18 ` Dan Williams
2021-09-02 17:09 ` Ben Widawsky [this message]
2021-08-30 18:49 ` [PATCH 1/3] cxl: Fixed defined but not used warnings Dan Williams
2021-08-30 19:06 ` Ben Widawsky
2021-09-02 17:14 ` [PATCH v2] " Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902170933.emi4justeyel5elf@intel.com \
--to=ben.widawsky@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox