From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26CF7C433EF for ; Thu, 7 Oct 2021 08:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 041A1610A5 for ; Thu, 7 Oct 2021 08:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240634AbhJGI0F (ORCPT ); Thu, 7 Oct 2021 04:26:05 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:41438 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240557AbhJGI0F (ORCPT ); Thu, 7 Oct 2021 04:26:05 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id C51E71C0B87; Thu, 7 Oct 2021 10:24:10 +0200 (CEST) Date: Thu, 7 Oct 2021 10:24:10 +0200 From: Pavel Machek To: Dan Williams Cc: stuart hayes , "linux-pci@vger.kernel.org" , "helgaas@kernel.org" , "kbusch@kernel.org" , "kw@linux.com" , "lukas@wunner.de" , "bhelgaas@google.com" , "linux-cxl@vger.kernel.org" , mariusz.tkaczyk@linux.intel.com Subject: Re: [PATCH v3] Add support for PCIe SSD status LED management Message-ID: <20211007082410.GA15698@duo.ucw.cz> References: <20210813213653.3760-1-stuart.w.hayes@gmail.com> <5d1eb958c13553d70e4bee7a7b342febcf1c02ee.camel@intel.com> <4bb26dc0-9b82-21d6-0257-d50ec206a130@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Thank you for the comments, Dan. > > > > I originally did submit something simple that just added a couple of > > sysfs attributes to allow userspace access to the _DSM, but Greg K-H > > said (1) that I shouldn't create new driver-specific sysfs files that do > > things that existing class drivers do, and that if I'm allowing LEDs to > > be controlled by the user, I have to use the LED subsystem, so I went > > with that. (See the end of > > https://patchwork.ozlabs.org/project/linux-pci/patch/20201110153735.585= 87-1-stuart.w.hayes@gmail.com/) >=20 > I agree with the general sentiment to adopt and extend existing ABIs > wherever possible, it's just not clear to me that the LED class driver > is the best fit. The Enclosure class infrastructure, in addition to LED drivers are not good fit for this. It is unlikely to be accepted. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYV6uqgAKCRAw5/Bqldv6 8pX/AKCudWgskrUbWQ1QmnLvqNkKxOlaPgCfU6mC54N8D2e/929nAEUBxg53nKw= =a4CR -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--