Re: [PATCH] cxl/cxlmem: Remove unused cxlmd field

[Ben Widawsky <ben.widawsky@intel.com>]

On 21-11-03 15:13:21, Dan Williams wrote:
> On Wed, Nov 3, 2021 at 1:41 PM <ira.weiny@intel.com> wrote:
> >
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > This field was left over when the connection between the cxl_memdev and
> > cxl_mem was tighter.  It is no longer set nor used so remove it.[1]
> >
> > [1] https://lore.kernel.org/linux-cxl/CAPcyv4hcgh2gb8qsS_UXTBSGqYfMPnC6p5kkvNUjm+V6kVKM5g@mail.gmail.com/
> 
> Looks good, although I'll probably fixup the subject to:
> 
>     cxl/memdev: Remove unused cxlmd field
> 
> ...to start to standardize on a prefix format of
> cxl/$(infrastructure_area/C file name). Previous commits used
> "cxl/mem:", but I think going forward that prefix can be used for
> changes related to the driver in "cxl_mem.ko". Where "cxl/memdev:" is
> for changes related to the base 'struct cxl_memdev' infrastructure.
> 
> The only reason that drivers/cxl/cxlmem.h has that redundant mention
> of "cxl" in filename is to avoid collisions with
> "arch/um/include/shared/mem.h" on ARCH=um builds. So "cxl/cxlmem:"
> triggered my naming finickiness.

I agree with the subject fixup, and patch is:
Acked-by: Ben Widawsky <ben.widawsky@intel.com>

I think there can be cases made for when it might not be a specific C file that
is in the subject, but this isn't one of them.