From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D7BC433F5 for ; Fri, 7 Jan 2022 20:27:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230138AbiAGU1T (ORCPT ); Fri, 7 Jan 2022 15:27:19 -0500 Received: from mga03.intel.com ([134.134.136.65]:26727 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231435AbiAGU1S (ORCPT ); Fri, 7 Jan 2022 15:27:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641587238; x=1673123238; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RUMOTc/ljJwy9J7MTHA84XDFs6eBGfTcIJ0nTk5hs3s=; b=RX/XdRD3hf+0qtmUMsDat5Nk10b3EaHvXGQpIKovrG7I4p8oszuKuagk oNRQiwpZKnXf53MbVB0ztdw2tSxCTGqdJ/hQJKfZhnbeqrs8wqTJtEPxo eu+AkZkJ5CRUvj4wwmpJUY24BKnS1G0OYCzLsm/7Ml991gAoCFs5OwM9d 4aw+sL303hBPtKjZV8uqjg1E9MjaP72u5AMKoanymzEK/yh1P5qjIupaR m+/ecMPl+p+EXfl/0Vu6VqIvwvkcNB4mkugMyL2+btg18n+bw5h+XXMn+ mhzMXskOLBTtntCwJviCWhY+53wTepkuNzMucAXPwRd7Al9mVfBCMxEbA w==; X-IronPort-AV: E=McAfee;i="6200,9189,10220"; a="242889138" X-IronPort-AV: E=Sophos;i="5.88,270,1635231600"; d="scan'208";a="242889138" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2022 12:27:18 -0800 X-IronPort-AV: E=Sophos;i="5.88,270,1635231600"; d="scan'208";a="668876217" Received: from alison-desk.jf.intel.com (HELO alison-desk) ([10.54.74.41]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2022 12:27:17 -0800 Date: Fri, 7 Jan 2022 12:32:27 -0800 From: Alison Schofield To: Dan Williams Cc: Ben Widawsky , Ira Weiny , Vishal Verma , Linux NVDIMM , linux-cxl@vger.kernel.org Subject: Re: [ndctl PATCH 4/7] cxl: add memdev partition information to cxl-list Message-ID: <20220107203227.GE803588@alison-desk> References: <78ff68a062f23cef48fb6ea1f91bcd7e11e4fa6e.1641233076.git.alison.schofield@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Thu, Jan 06, 2022 at 01:51:47PM -0800, Dan Williams wrote: > On Mon, Jan 3, 2022 at 12:11 PM wrote: > > > > From: Alison Schofield > > > > Add information useful for managing memdev partitions to cxl-list > > output. Include all of the fields from GET_PARTITION_INFO and the > > partitioning related fields from the IDENTIFY mailbox command. > > > > "partition":{ > > Perhaps call it "parition_info"? > Got it! > > "active_volatile_capacity":273535729664, > > "active_persistent_capacity":0, > > "next_volatile_capacity":0, > > "next_persistent_capacity":0, > > "total_capacity":273535729664, > > "volatile_only_capacity":0, > > "persistent_only_capacity":0, > > "partition_alignment":268435456 > > } > > > > } > > ] > > ---- > > +-P:: > > +--partition:: > > + Include partition information in the memdev listing. Example listing: > > How about -I/--partition for partition "Info". I had earmarked -P for > including "Port" object in the listing. Sure. -I it is! > > Other than that, looks good: > > Reviewed-by: Dan Williams > snip