From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51742C433F5 for ; Fri, 7 Jan 2022 20:47:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229472AbiAGUrT (ORCPT ); Fri, 7 Jan 2022 15:47:19 -0500 Received: from mga07.intel.com ([134.134.136.100]:10469 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiAGUrT (ORCPT ); Fri, 7 Jan 2022 15:47:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641588439; x=1673124439; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=EwJKm/cfMNOSUAQYjxrqkuKRTPRHV1fvwr0IyL7FZnQ=; b=b3816tmgnZpPnXh3yLgsCSuWcPsVa2cj++B691nJfPwSj09Jd2LYmbbw hCLRKSa+C9R61Ee/u1HtVz7cDQOqMgOeMhuk1s6os2uf68tkU+PWLSHhh CrZstd90NOaWXTsXPjUKtbXlMch6MUyi06dmKveriyUsQnohoNug622tr D0xKLy9EVOb91a/nFhuGL4/3pssRn1eBGVRW56B8rH2BOLgz4ULYg3mHL EdMyI9+B+9ERz8hTsXdVhsEVSUQ9JR1oDfal1Fo/YsQOIx6F8EilHVOek aBNLl+bscfPw4u4NsouORFT5R3G94Hsrzy//eTyZLBTj6+AiVMolzOt3N A==; X-IronPort-AV: E=McAfee;i="6200,9189,10220"; a="306305050" X-IronPort-AV: E=Sophos;i="5.88,270,1635231600"; d="scan'208";a="306305050" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2022 12:47:19 -0800 X-IronPort-AV: E=Sophos;i="5.88,270,1635231600"; d="scan'208";a="612294581" Received: from alison-desk.jf.intel.com (HELO alison-desk) ([10.54.74.41]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2022 12:47:18 -0800 Date: Fri, 7 Jan 2022 12:52:28 -0800 From: Alison Schofield To: Ben Widawsky , Dan Williams , Vishal Verma , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org Subject: Re: [ndctl PATCH 4/7] cxl: add memdev partition information to cxl-list Message-ID: <20220107205228.GF803588@alison-desk> References: <78ff68a062f23cef48fb6ea1f91bcd7e11e4fa6e.1641233076.git.alison.schofield@intel.com> <20220106204905.GE178135@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220106204905.GE178135@iweiny-DESK2.sc.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Thu, Jan 06, 2022 at 12:49:05PM -0800, Ira Weiny wrote: > On Mon, Jan 03, 2022 at 12:16:15PM -0800, Schofield, Alison wrote: > > From: Alison Schofield > > > > "Users will want to be able to check the current partition information. In > addition they will need to know the capacity values to form a valid set > partition information command." > I do see the pattern you are after. Problem statement separate from solution statement. Will reword. > > Add information useful for managing memdev partitions to cxl-list > ^ > "optional" > > > output. Include all of the fields from GET_PARTITION_INFO and the > > partitioning related fields from the IDENTIFY mailbox command. > > > > "Sample output for this section is:" > > > "partition":{ > > "active_volatile_capacity":273535729664, > > "active_persistent_capacity":0, > > "next_volatile_capacity":0, > > "next_persistent_capacity":0, > > "total_capacity":273535729664, > > "volatile_only_capacity":0, > > "persistent_only_capacity":0, > > "partition_alignment":268435456 > > } > > snip > > + if (jobj) > > + json_object_object_add(jpart, "partition_alignment", jobj); > > + > > + return jpart; > > + > > +err_cmd: > > Doesn't this need to be called always, not just on error? cxl_cmd_unref(), sure does. Thanks for the catch! > > Ira >