From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56AAC433EF for ; Thu, 27 Jan 2022 16:43:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231757AbiA0Qnh convert rfc822-to-8bit (ORCPT ); Thu, 27 Jan 2022 11:43:37 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4530 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244083AbiA0Qmn (ORCPT ); Thu, 27 Jan 2022 11:42:43 -0500 Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Jl5rt0PcBz67ydD; Fri, 28 Jan 2022 00:39:10 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Thu, 27 Jan 2022 17:42:41 +0100 Received: from localhost (10.47.67.119) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 27 Jan 2022 16:42:40 +0000 Date: Thu, 27 Jan 2022 16:42:33 +0000 From: Jonathan Cameron To: Alex =?ISO-8859-1?Q?Benn=E9e?= CC: , Marcel Apfelbaum , "Michael S . Tsirkin" , Igor Mammedov , , Ben Widawsky , "Peter Maydell" , , "Shameerali Kolothum Thodi" , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Saransh Gupta1 , Shreyas Shah , Chris Browy , Samarth Saxena , "Dan Williams" Subject: Re: [PATCH v4 00/42] CXl 2.0 emulation Support Message-ID: <20220127164233.00007514@Huawei.com> In-Reply-To: <87sft98d6f.fsf@linaro.org> References: <20220124171705.10432-1-Jonathan.Cameron@huawei.com> <87sft98d6f.fsf@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.47.67.119] X-ClientProxiedBy: lhreml741-chm.china.huawei.com (10.201.108.191) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Thu, 27 Jan 2022 14:22:52 +0000 Alex Bennée wrote: > Jonathan Cameron writes: > > > Previous version was RFC v3: CXL 2.0 Support. > > No longer an RFC as I would consider the vast majority of this > > to be ready for detailed review. There are still questions called > > out in some patches however. > > I've been through and added comments through the first half of the > patches. I'll see if I can get to the second half next week however if > you beat me to it with a re-rev I expect some ripples from the requested > changes. > > Aside from ensuring the rest of the builds work: > > https://gitlab.com/stsquad/qemu/-/pipelines/456700583/failures > > it looks pretty good to me. I await the next version ;-) > Thanks for ploughing through them - it's a great help. Hopefully I'll get a new version out before you get back to them. The CI certainly threw up some unexpected issues alongside the bugs and wrong assumptions and build issues you pointed out. * can't have a field called ERROR in a register on some archs * doesn't work if you don't push the tags on the tree... (win builds) but should be clean in next version. Thanks, Jonathan