From: Vishal Verma <vishal.l.verma@intel.com>
To: <linux-cxl@vger.kernel.org>
Cc: <nvdimm@lists.linux.dev>, Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: [ndctl PATCH v2 3/3] cxl/filter: Fix an uninitialized pointer dereference
Date: Tue, 23 Aug 2022 01:45:27 -0600 [thread overview]
Message-ID: <20220823074527.404435-4-vishal.l.verma@intel.com> (raw)
In-Reply-To: <20220823074527.404435-1-vishal.l.verma@intel.com>
Static analysis points out that there was a chance that 'jdecoder' could
be used while uninitialized in walk_decoders(). Initialize it to NULL to
avoid this.
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
cxl/filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cxl/filter.c b/cxl/filter.c
index 9a3de8c..56c6599 100644
--- a/cxl/filter.c
+++ b/cxl/filter.c
@@ -796,7 +796,7 @@ static void walk_decoders(struct cxl_port *port, struct cxl_filter_params *p,
cxl_decoder_foreach(port, decoder) {
const char *devname = cxl_decoder_get_devname(decoder);
struct json_object *jchildregions = NULL;
- struct json_object *jdecoder;
+ struct json_object *jdecoder = NULL;
if (!p->decoders)
goto walk_children;
--
2.37.2
next prev parent reply other threads:[~2022-08-23 7:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 7:45 [ndctl PATCH v2 0/3] cxl: static analysis fixes Vishal Verma
2022-08-23 7:45 ` [ndctl PATCH v2 1/3] cxl/region: fix a dereferecnce after NULL check Vishal Verma
2022-08-23 17:25 ` Dan Williams
2022-08-24 0:03 ` Dave Jiang
2022-08-24 9:30 ` Jonathan Cameron
2022-08-23 7:45 ` [ndctl PATCH v2 2/3] libcxl: fox a resource leak and a forward " Vishal Verma
2022-08-23 17:27 ` Dan Williams
2022-08-24 0:04 ` Dave Jiang
2022-08-23 7:45 ` Vishal Verma [this message]
2022-08-23 17:27 ` [ndctl PATCH v2 3/3] cxl/filter: Fix an uninitialized pointer dereference Dan Williams
2022-08-24 0:04 ` Dave Jiang
2022-08-24 9:37 ` [ndctl PATCH v2 0/3] cxl: static analysis fixes Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823074527.404435-4-vishal.l.verma@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox