From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH 2/3] cxl/mem: Remove unused CXL_CMD_FLAG_NONE define
Date: Thu, 5 Jan 2023 17:32:21 +0000 [thread overview]
Message-ID: <20230105173221.00007555@Huawei.com> (raw)
In-Reply-To: <20221222-cxl-misc-v1-2-9343bab16e72@intel.com>
On Tue, 27 Dec 2022 06:52:10 -0800
Ira Weiny <ira.weiny@intel.com> wrote:
> CXL_CMD_FLAG_NONE is not used, remove it.
>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
That is a bit odd. Good to get rid of it.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/cxl/cxlmem.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> index ab138004f644..2d85776236dd 100644
> --- a/drivers/cxl/cxlmem.h
> +++ b/drivers/cxl/cxlmem.h
> @@ -393,7 +393,6 @@ struct cxl_mem_command {
> struct cxl_command_info info;
> enum cxl_opcode opcode;
> u32 flags;
> -#define CXL_CMD_FLAG_NONE 0
> #define CXL_CMD_FLAG_FORCE_ENABLE BIT(0)
> };
>
>
next prev parent reply other threads:[~2023-01-10 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 14:52 [PATCH 0/3] CXL: Miscellaneous fixes Ira Weiny
2022-12-27 14:52 ` [PATCH 1/3] cxl/mem: Fix command comment Ira Weiny
2023-01-04 3:02 ` Dan Williams
2023-01-05 17:36 ` Jonathan Cameron
2023-01-05 18:01 ` Ira Weiny
2022-12-27 14:52 ` [PATCH 2/3] cxl/mem: Remove unused CXL_CMD_FLAG_NONE define Ira Weiny
2023-01-05 17:32 ` Jonathan Cameron [this message]
2022-12-27 14:52 ` [PATCH 3/3] cxl/uapi: Add warning on CXL command enum Ira Weiny
2023-01-05 17:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105173221.00007555@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox