From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87747C636CC for ; Wed, 8 Feb 2023 17:33:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230477AbjBHRdJ (ORCPT ); Wed, 8 Feb 2023 12:33:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231636AbjBHRdI (ORCPT ); Wed, 8 Feb 2023 12:33:08 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6F7D3251B; Wed, 8 Feb 2023 09:33:06 -0800 (PST) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PBn5y3YWyz6J7Wr; Thu, 9 Feb 2023 01:28:38 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Wed, 8 Feb 2023 17:33:04 +0000 Date: Wed, 8 Feb 2023 17:33:03 +0000 From: Jonathan Cameron To: Dan Williams CC: , , , Subject: Re: [PATCH 14/18] dax/hmem: Drop unnecessary dax_hmem_remove() Message-ID: <20230208173303.00007b2c@Huawei.com> In-Reply-To: <167564542679.847146.17174404738816053065.stgit@dwillia2-xfh.jf.intel.com> References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564542679.847146.17174404738816053065.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Sun, 05 Feb 2023 17:03:46 -0800 Dan Williams wrote: > Empty driver remove callbacks can just be elided. > > Signed-off-by: Dan Williams Reviewed-by: Jonathan Cameron > --- > drivers/dax/hmem/hmem.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c > index 1bf040dbc834..c7351e0dc8ff 100644 > --- a/drivers/dax/hmem/hmem.c > +++ b/drivers/dax/hmem/hmem.c > @@ -44,15 +44,8 @@ static int dax_hmem_probe(struct platform_device *pdev) > return 0; > } > > -static int dax_hmem_remove(struct platform_device *pdev) > -{ > - /* devm handles teardown */ > - return 0; > -} > - > static struct platform_driver dax_hmem_driver = { > .probe = dax_hmem_probe, > - .remove = dax_hmem_remove, > .driver = { > .name = "hmem", > }, >