Re: [PATCH v2] cxl/pci: Set the device timestamp

[Davidlohr Bueso <dave@stgolabs.net>]

On Wed, 22 Feb 2023, Nabeel M Mohamed wrote:

>So, I'm wondering if there's any checklist listing the prerequisites
>for submitting a patch to the CXL driver - for instance, requirements
>on adding new tests for coverage, any existing CXL regression suites
>that the patch must pass, etc.

Btw we might want to support timestamps in the mock device, no? I am
aware that qemu has both get and set.

--<8-----
[PATCH] cxl/test: Add mock test for set_timestamp

Support the command testing in a unit-test fashion.

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
  tools/testing/cxl/test/mem.c | 23 +++++++++++++++++++++++
  1 file changed, 23 insertions(+)

diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
index 9263b04d35f7..09511f2fbe54 100644
--- a/tools/testing/cxl/test/mem.c
+++ b/tools/testing/cxl/test/mem.c
@@ -98,6 +98,7 @@ struct cxl_mockmem_data {
  	int master_limit;
  	struct mock_event_store mes;
  	u8 event_buf[SZ_4K];
+	u64 timestamp;
  };
  
  static struct mock_event_log *event_find_log(struct device *dev, int log_type)
@@ -361,6 +362,21 @@ struct cxl_event_mem_module mem_module = {
  	}
  };
  
+static int mock_set_timestamp(struct cxl_dev_state *cxlds, struct cxl_mbox_cmd *cmd)
+{
+	struct cxl_mockmem_data *mdata = dev_get_drvdata(cxlds->dev);
+	struct cxl_mbox_set_timestamp_in *ts = cmd->payload_in;
+
+	if (cmd->size_in != sizeof(*ts))
+		return -EINVAL;
+
+	if (cmd->size_out != 0)
+		return -EINVAL;
+
+	mdata->timestamp = le64_to_cpu(ts->timestamp);
+	return 0;
+}
+
  static void cxl_mock_add_event_logs(struct mock_event_store *mes)
  {
  	put_unaligned_le16(CXL_GMER_VALID_CHANNEL | CXL_GMER_VALID_RANK,
@@ -894,6 +910,9 @@ static int cxl_mock_mbox_send(struct cxl_dev_state *cxlds, struct cxl_mbox_cmd *
  	int rc = -EIO;
  
  	switch (cmd->opcode) {
+	case CXL_MBOX_OP_SET_TIMESTAMP:
+		rc = mock_set_timestamp(cxlds, cmd);
+		break;
  	case CXL_MBOX_OP_GET_SUPPORTED_LOGS:
  		rc = mock_gsl(cmd);
  		break;
@@ -1010,6 +1029,10 @@ static int cxl_mock_mem_probe(struct platform_device *pdev)
  	if (rc)
  		return rc;
  
+	rc = cxl_set_timestamp(cxlds);
+	if (rc)
+		return rc;
+
  	rc = cxl_dev_state_identify(cxlds);
  	if (rc)
  		return rc;
-- 
2.39.0