From: Jehoon Park <jehoon.park@samsung.com>
To: linux-cxl@vger.kernel.org
Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, alison.schofield@intel.com,
bwidawsk@kernel.org, jehoon park <jehoon.park@samsung.com>
Subject: [ndctl patch RFC 1/2] libcxl: add accessors for IDENTIFY command
Date: Tue, 7 Mar 2023 17:21:01 +0900 [thread overview]
Message-ID: <20230307082102.27195-2-jehoon.park@samsung.com> (raw)
In-Reply-To: <20230307082102.27195-1-jehoon.park@samsung.com>
From: jehoon park <jehoon.park@samsung.com>
Add accessors to retrieve event log size, poison list size,
inject poison limit, poison handling capabilities and QoS
telemetry capabilities from output payload of IDENTIFY command.
Signed-off-by: jehoon park <jehoon.park@samsung.com>
---
cxl/lib/libcxl.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++
cxl/lib/libcxl.sym | 11 +++++++
cxl/lib/private.h | 11 +++++++
cxl/libcxl.h | 16 ++++++++++
4 files changed, 111 insertions(+)
diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c
index 59e5bdb..12d8e63 100644
--- a/cxl/lib/libcxl.c
+++ b/cxl/lib/libcxl.c
@@ -3775,6 +3775,79 @@ cxl_cmd_identify_get_persistent_only_size(struct cxl_cmd *cmd)
return cxl_capacity_to_bytes(c->persistent_capacity);
}
+CXL_EXPORT int
+cxl_cmd_identify_get_event_log_size(struct cxl_cmd *cmd,
+ enum cxl_identify_event event)
+{
+ struct cxl_cmd_identify *id =
+ (struct cxl_cmd_identify *)cmd->send_cmd->out.payload;
+ int rc = cxl_cmd_validate_status(cmd, CXL_MEM_COMMAND_ID_IDENTIFY);
+ if (rc)
+ return rc;
+
+ switch (event) {
+ case CXL_IDENTIFY_INFO:
+ return le16_to_cpu(id->info_event_log_size);
+ case CXL_IDENTIFY_WARN:
+ return le16_to_cpu(id->warning_event_log_size);
+ case CXL_IDENTIFY_FAIL:
+ return le16_to_cpu(id->failure_event_log_size);
+ case CXL_IDENTIFY_FATAL:
+ return le16_to_cpu(id->fatal_event_log_size);
+ default:
+ return -EINVAL;
+ }
+}
+
+CXL_EXPORT int cxl_cmd_identify_get_poison_list_max(struct cxl_cmd *cmd)
+{
+ unsigned int max_records = 0;
+ struct cxl_cmd_identify *id =
+ (struct cxl_cmd_identify *)cmd->send_cmd->out.payload;
+ int rc = cxl_cmd_validate_status(cmd, CXL_MEM_COMMAND_ID_IDENTIFY);
+ if (rc)
+ return rc;
+
+ for (int i = 0; i < 3; i++)
+ max_records += id->poison_list_max_mer[i] << (8 * i);
+
+ return max_records;
+}
+
+CXL_EXPORT int cxl_cmd_identify_get_inject_poison_limit(struct cxl_cmd *cmd)
+{
+ cmd_get_field_u16(cmd, identify, IDENTIFY, inject_poison_limit);
+}
+
+CXL_EXPORT int cxl_cmd_identify_injects_persistent_poison(struct cxl_cmd *cmd)
+{
+ cmd_get_field_u8_mask(
+ cmd, identify, IDENTIFY, poison_caps,
+ CXL_CMD_IDENTIFY_POISON_HANDLING_CAPABILITIES_INJECTS_PERSISTENT_POISON);
+}
+
+CXL_EXPORT int cxl_cmd_identify_scans_for_poison(struct cxl_cmd *cmd)
+{
+ cmd_get_field_u8_mask(
+ cmd, identify, IDENTIFY, poison_caps,
+ CXL_CMD_IDENTIFY_POISON_HANDLING_CAPABILITIES_SCANS_FOR_POISON);
+}
+
+CXL_EXPORT int cxl_cmd_identify_egress_port_congestion(struct cxl_cmd *cmd)
+{
+ cmd_get_field_u8_mask(
+ cmd, identify, IDENTIFY, qos_telemetry_caps,
+ CXL_CMD_IDENTIFY_QOS_TELEMETRY_CAPABILITIES_EGRESS_PORT_CONGESTION);
+}
+
+CXL_EXPORT int
+cxl_cmd_identify_temporary_throughput_reduction(struct cxl_cmd *cmd)
+{
+ cmd_get_field_u8_mask(
+ cmd, identify, IDENTIFY, qos_telemetry_caps,
+ CXL_CMD_IDENTIFY_QOS_TELEMETRY_CAPABILITIES_TEMPORARY_THROUGHPUT_REDUCTION);
+}
+
CXL_EXPORT struct cxl_cmd *cxl_cmd_new_raw(struct cxl_memdev *memdev,
int opcode)
{
diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym
index 1c6177c..2bd209e 100644
--- a/cxl/lib/libcxl.sym
+++ b/cxl/lib/libcxl.sym
@@ -249,3 +249,14 @@ global:
cxl_decoder_create_ram_region;
cxl_region_get_daxctl_region;
} LIBCXL_4;
+
+LIBCXL_6 {
+global:
+ cxl_cmd_identify_get_event_log_size;
+ cxl_cmd_identify_get_poison_list_max;
+ cxl_cmd_identify_get_inject_poison_limit;
+ cxl_cmd_identify_injects_persistent_poison;
+ cxl_cmd_identify_scans_for_poison;
+ cxl_cmd_identify_egress_port_congestion;
+ cxl_cmd_identify_temporary_throughput_reduction;
+} LIBCXL_5;
diff --git a/cxl/lib/private.h b/cxl/lib/private.h
index d648992..aab1552 100644
--- a/cxl/lib/private.h
+++ b/cxl/lib/private.h
@@ -211,6 +211,17 @@ struct cxl_cmd_identify {
u8 qos_telemetry_caps;
} __attribute__((packed));
+/* CXL 3.0 8.2.9.8.1.1 Identify Memory Device Poison Handling Capabilities */
+#define CXL_CMD_IDENTIFY_POISON_HANDLING_CAPABILITIES_INJECTS_PERSISTENT_POISON \
+ BIT(0)
+#define CXL_CMD_IDENTIFY_POISON_HANDLING_CAPABILITIES_SCANS_FOR_POISON BIT(1)
+
+/* CXL 3.0 8.2.9.8.1.1 Identify Memory Device QoS Telemetry Capabilities */
+#define CXL_CMD_IDENTIFY_QOS_TELEMETRY_CAPABILITIES_EGRESS_PORT_CONGESTION \
+ BIT(0)
+#define CXL_CMD_IDENTIFY_QOS_TELEMETRY_CAPABILITIES_TEMPORARY_THROUGHPUT_REDUCTION \
+ BIT(1)
+
struct cxl_cmd_get_lsa_in {
le32 offset;
le32 length;
diff --git a/cxl/libcxl.h b/cxl/libcxl.h
index 54d9f10..1856bee 100644
--- a/cxl/libcxl.h
+++ b/cxl/libcxl.h
@@ -334,6 +334,22 @@ unsigned long long cxl_cmd_identify_get_volatile_only_size(struct cxl_cmd *cmd);
unsigned long long cxl_cmd_identify_get_persistent_only_size(struct cxl_cmd *cmd);
unsigned long long cxl_cmd_identify_get_partition_align(struct cxl_cmd *cmd);
unsigned int cxl_cmd_identify_get_label_size(struct cxl_cmd *cmd);
+
+enum cxl_identify_event {
+ CXL_IDENTIFY_INFO,
+ CXL_IDENTIFY_WARN,
+ CXL_IDENTIFY_FAIL,
+ CXL_IDENTIFY_FATAL,
+};
+
+int cxl_cmd_identify_get_event_log_size(struct cxl_cmd *cmd,
+ enum cxl_identify_event event);
+int cxl_cmd_identify_get_poison_list_max(struct cxl_cmd *cmd);
+int cxl_cmd_identify_get_inject_poison_limit(struct cxl_cmd *cmd);
+int cxl_cmd_identify_injects_persistent_poison(struct cxl_cmd *cmd);
+int cxl_cmd_identify_scans_for_poison(struct cxl_cmd *cmd);
+int cxl_cmd_identify_egress_port_congestion(struct cxl_cmd *cmd);
+int cxl_cmd_identify_temporary_throughput_reduction(struct cxl_cmd *cmd);
struct cxl_cmd *cxl_cmd_new_get_health_info(struct cxl_memdev *memdev);
int cxl_cmd_health_info_get_maintenance_needed(struct cxl_cmd *cmd);
int cxl_cmd_health_info_get_performance_degraded(struct cxl_cmd *cmd);
--
2.17.1
next prev parent reply other threads:[~2023-03-07 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230307081917epcas2p1accc8f7bf3f31e08525684abb2efa788@epcas2p1.samsung.com>
2023-03-07 8:21 ` [ndctl patch RFC 0/2] add support for IDENTIFY command Jehoon Park
2023-03-07 8:21 ` Jehoon Park [this message]
2023-03-07 8:21 ` [ndctl patch RFC 2/2] cxl: add identify command to cxl tool Jehoon Park
2023-03-07 20:18 ` [ndctl patch RFC 0/2] add support for IDENTIFY command Alison Schofield
2023-03-08 9:01 ` Jehoon Park
2023-03-08 18:22 ` Ira Weiny
2023-03-08 21:58 ` Alison Schofield
2023-03-10 6:54 ` Jehoon Park
2023-03-10 9:45 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307082102.27195-2-jehoon.park@samsung.com \
--to=jehoon.park@samsung.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox