From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54EDBC77B7C for ; Fri, 12 May 2023 15:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241233AbjELPgs (ORCPT ); Fri, 12 May 2023 11:36:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233395AbjELPgr (ORCPT ); Fri, 12 May 2023 11:36:47 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29525B9 for ; Fri, 12 May 2023 08:36:45 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QHt9x3xRCz67Lqc; Fri, 12 May 2023 23:35:01 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 12 May 2023 16:36:43 +0100 Date: Fri, 12 May 2023 16:36:42 +0100 From: Jonathan Cameron To: Dave Jiang CC: , Dan Williams , , , Subject: Re: [PATCH v5 14/14] cxl/mem: Add debugfs output for QTG related data Message-ID: <20230512163642.00002715@Huawei.com> In-Reply-To: <168357889673.2756219.5112791678818283230.stgit@djiang5-mobl3> References: <168357873843.2756219.5839806150467356492.stgit@djiang5-mobl3> <168357889673.2756219.5112791678818283230.stgit@djiang5-mobl3> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Mon, 08 May 2023 13:48:16 -0700 Dave Jiang wrote: > Add debugfs output to /sys/kernel/debug/cxl/memX/qtgmap > The debugfs attribute will dump out all the DSMAS ranges and the associated > QTG ID exported by the CXL device CDAT. > > Suggested-by: Dan Williams > Signed-off-by: Dave Jiang LTGM, though seems we haven't been keeping up with ABI docs for other stuff in debugfs. That wants fixing but is unrelated to this. Reviewed-by: Jonathan Cameron > > --- > v4: > - Use cxlds->qos_list instead of the stray cxlmd->qos_list > --- > Documentation/ABI/testing/debugfs-cxl | 11 +++++++++++ > MAINTAINERS | 1 + > drivers/cxl/mem.c | 17 +++++++++++++++++ > 3 files changed, 29 insertions(+) > create mode 100644 Documentation/ABI/testing/debugfs-cxl > > diff --git a/Documentation/ABI/testing/debugfs-cxl b/Documentation/ABI/testing/debugfs-cxl > new file mode 100644 > index 000000000000..0f36eeb7e59b > --- /dev/null > +++ b/Documentation/ABI/testing/debugfs-cxl > @@ -0,0 +1,11 @@ > +What: /sys/kernel/debug/cxl/memX/qtg_map > +Date: Mar, 2023 > +KernelVersion: v6.4 > +Contact: linux-cxl@vger.kernel.org > +Description: > + (RO) Entries of all Device Physical Address (DPA) ranges > + provided by the device Coherent Device Attributes Table (CDAT) > + Device Scoped Memory Affinity Structure (DSMAS) entries with > + the matching QoS Throttling Group (QTG) id calculated from the > + latency and bandwidth of the CXL path from the memory device > + to the CPU. Curious. This file should already exist as there is clearly more debugfs ABI from the code below. Perhaps a precursor patch to create the file and document existing interfaces? > diff --git a/MAINTAINERS b/MAINTAINERS > index fd8c4c560f8d..256e4e57017c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5171,6 +5171,7 @@ M: Ben Widawsky > M: Dan Williams > L: linux-cxl@vger.kernel.org > S: Maintained > +F: Documentation/ABI/testing/debugfs-cxl > F: drivers/cxl/ > F: include/uapi/linux/cxl_mem.h > > diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c > index 39c4b54f0715..587e261a7f76 100644 > --- a/drivers/cxl/mem.c > +++ b/drivers/cxl/mem.c > @@ -45,6 +45,22 @@ static int cxl_mem_dpa_show(struct seq_file *file, void *data) > return 0; > } > > +static int cxl_mem_qtg_show(struct seq_file *file, void *data) > +{ > + struct device *dev = file->private; > + struct cxl_memdev *cxlmd = to_cxl_memdev(dev); > + struct cxl_dev_state *cxlds = cxlmd->cxlds; > + struct perf_prop_entry *perf; > + > + list_for_each_entry(perf, &cxlds->perf_list, list) { > + seq_printf(file, "%08llx-%08llx : QoS Class: %u\n", > + perf->dpa_range.start, perf->dpa_range.end, > + perf->qos_class); > + } > + > + return 0; > +} > + > static int devm_cxl_add_endpoint(struct device *host, struct cxl_memdev *cxlmd, > struct cxl_dport *parent_dport) > { > @@ -117,6 +133,7 @@ static int cxl_mem_probe(struct device *dev) > > dentry = cxl_debugfs_create_dir(dev_name(dev)); > debugfs_create_devm_seqfile(dev, "dpamem", dentry, cxl_mem_dpa_show); > + debugfs_create_devm_seqfile(dev, "qtgmap", dentry, cxl_mem_qtg_show); > rc = devm_add_action_or_reset(dev, remove_debugfs, dentry); > if (rc) > return rc; > >