From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <qemu-devel@nongnu.org>, Michael Tsirkin <mst@redhat.com>,
Fan Ni <fan.ni@samsung.com>
Cc: linux-cxl@vger.kernel.org, linuxarm@huawei.com,
"Ira Weiny" <ira.weiny@intel.com>,
"Michael Roth" <michael.roth@amd.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Dave Jiang" <dave.jiang@intel.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Mike Maslenkin" <mike.maslenkin@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Subject: [PATCH v8 0/4] hw/cxl: Poison get, inject, clear
Date: Fri, 26 May 2023 18:00:06 +0100 [thread overview]
Message-ID: <20230526170010.574-1-Jonathan.Cameron@huawei.com> (raw)
v8: Formatting fixes for QMP docs from Markus Armbruster (thanks!)
The bswap naming discussions seems to have died down, so I'll stick
with this version (24)
Precursors now all upstream which make this email easier to write :)
The kernel support for Poison handling is now upstream.
This code has been very useful for testing and helped identify various
corner cases.
Updated cover letter.
The series supports:
1) Injection of variable length poison regions via QMP (to fake real
memory corruption and ensure we deal with odd overflow corner cases
such as clearing the middle of a large region making the list overflow
as we go from one long entry to two smaller entries.
2) Read of poison list via the CXL mailbox.
3) Injection via the poison injection mailbox command (limited to 64 byte
entries - spec constraint)
4) Clearing of poison injected via either method.
The implementation is meant to be a valid combination of impdef choices
based on what the spec allowed. There are a number of places where it could
be made more sophisticated that we might consider in future:
* Fusing adjacent poison entries if the types match.
* Separate injection list and main poison list, to test out limits on
injected poison list being smaller than the main list.
* Poison list overflow event (needs event log support in general)
* Connecting up to the poison list error record generation (rather complex
and not needed for currently kernel handling testing).
* Triggering the synchronous and asynchronous errors that occur on reads
and writes of the memory when the host receives poison.
As the kernel code is currently fairly simple, it is likely that the above
does not yet matter but who knows what will turn up in future!
Ira Weiny (1):
bswap: Add the ability to store to an unaligned 24 bit field
Jonathan Cameron (3):
hw/cxl: QMP based poison injection support
hw/cxl: Add poison injection via the mailbox.
hw/cxl: Add clear poison mailbox command support.
docs/devel/loads-stores.rst | 2 +
qapi/cxl.json | 21 ++++
include/hw/cxl/cxl.h | 1 +
include/hw/cxl/cxl_device.h | 21 ++++
include/qemu/bswap.h | 25 +++++
hw/cxl/cxl-mailbox-utils.c | 214 ++++++++++++++++++++++++++++++++++++
hw/mem/cxl_type3.c | 93 ++++++++++++++++
hw/mem/cxl_type3_stubs.c | 6 +
8 files changed, 383 insertions(+)
--
2.39.2
next reply other threads:[~2023-05-26 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 17:00 Jonathan Cameron [this message]
2023-05-26 17:00 ` [PATCH v8 1/4] bswap: Add the ability to store to an unaligned 24 bit field Jonathan Cameron
2024-06-21 7:10 ` Philippe Mathieu-Daudé
2023-05-26 17:00 ` [PATCH v8 2/4] hw/cxl: QMP based poison injection support Jonathan Cameron
2023-05-26 17:00 ` [PATCH v8 3/4] hw/cxl: Add poison injection via the mailbox Jonathan Cameron
2023-05-26 17:00 ` [PATCH v8 4/4] hw/cxl: Add clear poison mailbox command support Jonathan Cameron
2023-06-23 6:59 ` [PATCH v8 0/4] hw/cxl: Poison get, inject, clear Michael S. Tsirkin
2023-06-23 12:06 ` Jonathan Cameron
2023-06-23 12:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526170010.574-1-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave.jiang@intel.com \
--cc=eblake@redhat.com \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=mike.maslenkin@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox