Re: [PATCH 1/2] hw/cxl: Update comments for Get Log

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Fri, 28 Jul 2023 09:57:04 -0700
Davidlohr Bueso <dave@stgolabs.net> wrote:

> The current notes regarding some of the literature in the spec
> no longer applies, update from 2.0 to 3.0.
> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Hi Davidlohr,

Thanks for tidying this bit up.

We aren't doing great on consistency of how we list the version numbers
in the QEMU code, but I'd like to definitely make it easier to tell
what is revision and what is section.

So I've tweak your changes here to the format

/* CXL r3.0 section xxxxxx: Section title */

and put it on top of my tree (I'll push out once I've finished queuing anything
else that is ready up on top.

Thanks,

Jonathan

> ---
>  hw/cxl/cxl-mailbox-utils.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c
> index 2819914e8d09..5152a83c6fdd 100644
> --- a/hw/cxl/cxl-mailbox-utils.c
> +++ b/hw/cxl/cxl-mailbox-utils.c
> @@ -608,7 +608,7 @@ static const QemuUUID cel_uuid = {
>                   0x96, 0xb1, 0x62, 0x3b, 0x3f, 0x17)
>  };
>  
> -/* 8.2.9.4.1 */
> +/* CXL 3.0 8.2.9.5.1 */
>  static CXLRetCode cmd_logs_get_supported(const struct cxl_cmd *cmd,
>                                           uint8_t *payload_in,
>                                           size_t len_in,
> @@ -634,7 +634,7 @@ static CXLRetCode cmd_logs_get_supported(const struct cxl_cmd *cmd,
>      return CXL_MBOX_SUCCESS;
>  }
>  
> -/* 8.2.9.4.2 */
> +/* CXL 3.0 8.2.9.5.2 */
>  static CXLRetCode cmd_logs_get_log(const struct cxl_cmd *cmd,
>                                     uint8_t *payload_in,
>                                     size_t len_in,
> @@ -651,12 +651,6 @@ static CXLRetCode cmd_logs_get_log(const struct cxl_cmd *cmd,
>      get_log = (void *)payload_in;
>  
>      /*
> -     * 8.2.9.4.2
> -     *   The device shall return Invalid Parameter if the Offset or Length
> -     *   fields attempt to access beyond the size of the log as reported by Get
> -     *   Supported Logs.
> -     *
> -     * XXX: Spec is wrong, "Invalid Parameter" isn't a thing.
>       * XXX: Spec doesn't address incorrect UUID incorrectness.
>       *
>       * The CEL buffer is large enough to fit all commands in the emulation, so