Linux CXL
 help / color / mirror / Atom feed
From: Jeongtae Park <jtp.park@samsung.com>
To: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Adam Manzanares <a.manzanares@samsung.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Ayush Mishra <ayush.m55@samsung.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>, Fan Ni <fan.ni@samsung.com>,
	gourry.memverge@gmail.com, linux-cxl@vger.kernel.org,
	Kyungsan Kim <ks0204.kim@samsung.com>,
	Wonjae Lee <wj28.lee@samsung.com>,
	Hojin Nam <hj96.nam@samsung.com>,
	Junhyeok Im <junhyeok.im@samsung.com>,
	Jehoon Park <jehoon.park@samsung.com>,
	Youngshin Park <yshin0.park@samsung.com>,
	Jeongtae Park <jeongtae.park@gmail.com>,
	Jeongtae Park <jtp.park@samsung.com>
Subject: hw/cxl: avoid build error with lower(<=9) gcc versions
Date: Sat, 14 Oct 2023 21:03:22 +0900	[thread overview]
Message-ID: <20231014120322.4145387-1-jtp.park@samsung.com> (raw)
In-Reply-To: CGME20231014120038epcas2p388517f5719bcd6517ff83580aebe9f53@epcas2p3.samsung.com

We are testing on the below branch[1] and getting the following build
error when using gcc-9 or gcc-7 (gcc-11 is ok).

I was reported in private to Jonathan Cameron, and he will get rid of
it soon.

This is just for your information and for keeping on list.

Thanks
/jtpark

[1]: https://gitlab.com/jic23/qemu/-/tree/cxl-2023-09-13/

Reported-by: Kyungsan Kim <ks0204.kim@samsung.com>
Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
---
 hw/cxl/cxl-component-utils.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/hw/cxl/cxl-component-utils.c b/hw/cxl/cxl-component-utils.c
index c022a90774..fd15d9a61e 100644
--- a/hw/cxl/cxl-component-utils.c
+++ b/hw/cxl/cxl-component-utils.c
@@ -325,9 +325,11 @@ void cxl_component_register_init_common(uint32_t *reg_state,
     case CXL2_ROOT_PORT:
     case CXL2_UPSTREAM_PORT:
     case CXL2_DOWNSTREAM_PORT:
-        init_cap_reg(RAS, 2, 2);
-        ras_init_common(reg_state, write_msk);
-        break;
+        {
+            init_cap_reg(RAS, 2, 2);
+            ras_init_common(reg_state, write_msk);
+            break;
+        }
     default:
         break;
     }
-- 
2.34.1


       reply	other threads:[~2023-10-14 12:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20231014120038epcas2p388517f5719bcd6517ff83580aebe9f53@epcas2p3.samsung.com>
2023-10-14 12:03 ` Jeongtae Park [this message]
2023-10-18 16:37   ` hw/cxl: avoid build error with lower(<=9) gcc versions Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231014120322.4145387-1-jtp.park@samsung.com \
    --to=jtp.park@samsung.com \
    --cc=a.manzanares@samsung.com \
    --cc=alison.schofield@intel.com \
    --cc=ayush.m55@samsung.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave@stgolabs.net \
    --cc=fan.ni@samsung.com \
    --cc=gourry.memverge@gmail.com \
    --cc=hj96.nam@samsung.com \
    --cc=jehoon.park@samsung.com \
    --cc=jeongtae.park@gmail.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=junhyeok.im@samsung.com \
    --cc=ks0204.kim@samsung.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=wj28.lee@samsung.com \
    --cc=yshin0.park@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox