From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F223527EEE for ; Mon, 16 Oct 2023 14:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3470483; Mon, 16 Oct 2023 07:08:08 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S8JmX2b8Pz6K6SG; Mon, 16 Oct 2023 22:05:48 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 16 Oct 2023 15:08:05 +0100 Date: Mon, 16 Oct 2023 15:08:04 +0100 From: Jonathan Cameron To: Terry Bowman CC: Robert Richter , Alison Schofield , Vishal Verma , "Ira Weiny" , Ben Widawsky , "Dan Williams" , Davidlohr Bueso , Dave Jiang , , , Bjorn Helgaas Subject: Re: [PATCH v11 10/20] cxl/pci: Introduce config option PCIEAER_CXL Message-ID: <20231016150804.000054aa@Huawei.com> In-Reply-To: References: <20230927154339.1600738-1-rrichter@amd.com> <20230927154339.1600738-11-rrichter@amd.com> <20231002154628.00004f9b@Huawei.com> <21fa3d41-3585-40b4-b919-d3b66557e9d8@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net > >>> diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c > >>> index 04107058739b..61ca21c020fa 100644 > >>> --- a/drivers/cxl/mem.c > >>> +++ b/drivers/cxl/mem.c > >>> @@ -157,6 +157,8 @@ static int cxl_mem_probe(struct device *dev) > >>> else > >>> endpoint_parent = &parent_port->dev; > >>> > >>> + devm_cxl_setup_parent_dport(dev, dport); > >> > >> devm calls can always fail (because if nothing else you have to register > >> some cleanup and that involves an allocation. If you want to ignore > >> that I'd expect a comment here. > >> > > > > We will add error handling here. > > > > Regards, > > Terry > > > > Found devm_cxl_setup_parent_dport() is a NULL function without return value. Hmm. Then it's not a devm function. I went looking and can't find it registering any cleanup so just rename it to cxl_setup_parent_dport() > > Regards, > Terry