From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BADA533CCA for ; Wed, 24 Jan 2024 15:48:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706111297; cv=none; b=kKlgcfaHrlMLR6JkOnQV/znc01T/Qck46xaCZyvWpIH5FmhQHYbOsKlBl8VdJGIqdW+lBSS4NqZWwTCO6OaC+lwd/00W8Ncu9gClO4UWp6famzU7hFT0PFdZrDzcQ7ammw1/HF19xBp0zPXb2d+q45ex7m8dETrCS6B5fV2bxZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706111297; c=relaxed/simple; bh=Uh0mxNwdT2tScbAicXmRM6NjgPDXO7bxQDsPHKMpUCI=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LeuDDqSId8bcMXElqVFpqtfXX810TBPZCfNKmlSGe77hZNcnxcDT9sPWLR6luS607WaqsV0qxBw2A1GyGSzQ6NoUIZLmxrNzm/tMaJ0EaAEnDNQkdyEOruAZEmcTJtTFoncqmtP0mxIla5vfAg18j17OmhqwUeAMyKsILcQSbtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TKpFX3wWPz6K5wt; Wed, 24 Jan 2024 23:45:36 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 0A5A2140684; Wed, 24 Jan 2024 23:48:11 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Jan 2024 15:48:10 +0000 Date: Wed, 24 Jan 2024 15:48:09 +0000 From: Jonathan Cameron To: CC: , , , , , , , , , "Fan Ni" Subject: Re: [PATCH v3 2/9] hw/cxl/cxl-mailbox-utils: Add dynamic capacity region representative and mailbox command support Message-ID: <20240124154809.0000026f@Huawei.com> In-Reply-To: <20231107180907.553451-3-nifan.cxl@gmail.com> References: <20231107180907.553451-1-nifan.cxl@gmail.com> <20231107180907.553451-3-nifan.cxl@gmail.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) > diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h > index 4f2ef0b899..334c51fddb 100644 > --- a/include/hw/cxl/cxl_device.h > +++ b/include/hw/cxl/cxl_device.h > @@ -235,6 +235,7 @@ typedef struct cxl_device_state { > uint64_t mem_size; > uint64_t pmem_size; > uint64_t vmem_size; > + bool is_dcd; Written but never read, so drop this.