From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <qemu-devel@nongnu.org>, <linux-cxl@vger.kernel.org>,
Fan Ni <fan.ni@samsung.com>, Michael Tsirkin <mst@redhat.com>
Cc: "Ira Weiny" <ira.weiny@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
peter.maydell@linaro.org, "Davidlohr Bueso" <dave@stgolabs.net>,
"Hyeonggon Yoo" <42.hyeyoo@gmail.com>,
"Li Zhijian" <lizhijian@fujitsu.com>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
linuxarm@huawei.com, "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 09/12] hw/mem/cxl_type3: Fix potential divide by zero reported by coverity
Date: Fri, 26 Jan 2024 12:01:29 +0000 [thread overview]
Message-ID: <20240126120132.24248-10-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20240126120132.24248-1-Jonathan.Cameron@huawei.com>
Fixes Coverity ID 1522368.
Currently error_fatal is set if interleave_ways_dec() is going to return 0
but we should handle that zero return explicitly.
Reported-by: Stefan Hajnoczi <stefanha@gmail.com>
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
Note this is a stop gap until a more complex HDM decoder verification series.
---
hw/mem/cxl_type3.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index 1b92a065a3..71fcb44613 100644
--- a/hw/mem/cxl_type3.c
+++ b/hw/mem/cxl_type3.c
@@ -794,8 +794,13 @@ static bool cxl_type3_dpa(CXLType3Dev *ct3d, hwaddr host_addr, uint64_t *dpa)
}
if (((uint64_t)host_addr < decoder_base) ||
(hpa_offset >= decoder_size)) {
- dpa_base += decoder_size /
- cxl_interleave_ways_dec(iw, &error_fatal);
+ int decoded_iw = cxl_interleave_ways_dec(iw, &error_fatal);
+
+ if (decoded_iw == 0) {
+ return false;
+ }
+
+ dpa_base += decoder_size / decoded_iw;
continue;
}
--
2.39.2
next prev parent reply other threads:[~2024-01-26 12:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 12:01 [PATCH v2 00/12 qemu] CXL emulation fixes and minor cleanup Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 01/12] cxl/cdat: Handle cdat table build errors Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 02/12] hw/mem/cxl_type3: Drop handling of failure of g_malloc0() and g_malloc() Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 03/12] hw/pci-bridge/cxl_upstream: Drop g_malloc() failure handling Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 04/12] cxl/cdat: Fix header sum value in CDAT checksum Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 05/12] hw/cxl/mbox: Remove dead code Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 06/12] hw/cxl/device: read from register values in mdev_reg_read() Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 07/12] hw/cxl: Pass CXLComponentState to cache_mem_ops Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 08/12] hw/cxl: Pass NULL for a NULL MemoryRegionOps Jonathan Cameron
2024-01-26 12:01 ` Jonathan Cameron [this message]
2024-01-26 12:01 ` [PATCH v2 10/12] tests/acpi: Allow update of DSDT.cxl Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 11/12] hw/i386: Fix _STA return value for ACPI0017 Jonathan Cameron
2024-01-26 12:01 ` [PATCH v2 12/12] tests/acpi: Update DSDT.cxl to reflect change _STA return value Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126120132.24248-10-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=42.hyeyoo@gmail.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lizhijian@fujitsu.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox