Re: [PATCH 1/2] hw/cxl: Add Transfer FW support

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Fri, 26 Jan 2024 09:17:13 -0800
Davidlohr Bueso <dave@stgolabs.net> wrote:

> On Fri, 26 Jan 2024, Jonathan Cameron wrote:
> 
> >On Mon,  8 Jan 2024 23:04:35 -0800
> >Davidlohr Bueso <dave@stgolabs.net> wrote:
> >  
> >> Per the latest 3.1 spec for supporting firmware update metadata
> >> (no actual buffers). Aborting a xfer is currently unsupported
> >> through a nop.
> >>
> >> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>  
> >Hi Davidlohr.
> >
> >Whilst we may never notice from the OS as we expect it to send valid
> >sets of transfers only, I'd like the emulation to incorporate more
> >of the validity checks the spec requires such as:
> >- Multiple part transfers must all be for same slot - any interleaved
> >  ones for other slots result in error.
> >- Retry of previous transfer or one that starts where previous transfer
> >  ended - otherwise Out of Order detected.
> >
> >So we have to hold state, and as such will have the information to
> >set the slot as occupied with just one extra flag stored to say it is
> >a FULL or END message.
> >
> >Otherwise lgtm.  
> 
> I will send a v2 with your feedback. Do you prefer just using your
> latest '2024-26-01-draft' branch?

Yes, that makes my life easiest (though I'm also find dealing with
rebases if you use something reasonable that isn't that)
Nestle it in as far down as possible but after the DCD changes.
Either before or after your scan media set (up to you - they'll
probably get grouped together anyway for sending to Michael).

Thanks!

Jonathan


> 
> Thanks,
> Davidlohr