Linux CXL
 help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-kernel@vger.kernel.org
Cc: linux-cxl@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	"Fabio M. De Francesco"
	<fabio.maria.de.francesco@linux.intel.com>,
	Ira Weiny <ira.weiny@intel.com>
Subject: [PATCH 0/2 v2] Add cond_guard() to conditional guards
Date: Mon,  5 Feb 2024 15:26:11 +0100	[thread overview]
Message-ID: <20240205142613.23914-1-fabio.maria.de.francesco@linux.intel.com> (raw)

Add cond_guard() macro to conditional guards and use it to replace an
open-coded up_read() in show_targetN() and remove a block marked by an
'out' label.

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Suggested-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Fabio M. De Francesco <fabio.maria.de.francesco@linux.intel.com>
---

Changes from RFC v4:
	Changed the interface of cond_guard() to take a variable to store
	a return code, the succes code and failure code, to enable a
	later check of the returned code in that variable.
Changes from RFC v5:
	Changed the interface of cond_guard() to take one or more statements
	in its second argument to conform to Dan's final suggestion
	(thanks).
Changes from v1:
	Fixed a grammar error in the commit message of 1/2; replaced the
	name of the second argument of cond_guard() with '_fail'
	according to Jonathan's comments (thanks). 

Fabio M. De Francesco (2):
  cleanup: Add cond_guard() to conditional guards
  cxl/region: Use cond_guard() in show_targetN()

 drivers/cxl/core/region.c | 16 ++++------------
 include/linux/cleanup.h   | 14 ++++++++++++++
 2 files changed, 18 insertions(+), 12 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-02-05 14:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05 14:26 Fabio M. De Francesco [this message]
2024-02-05 14:26 ` [PATCH 1/2 v2] cleanup: Add cond_guard() to conditional guards Fabio M. De Francesco
2024-02-05 14:28   ` Jonathan Cameron
2024-02-05 17:14   ` Dave Jiang
2024-02-05 19:02   ` Dan Williams
2024-02-05 22:02     ` Ira Weiny
2024-02-05 23:11       ` Dan Williams
2024-02-05 23:56         ` Ira Weiny
2024-02-05 14:26 ` [PATCH 2/2 v2] cxl/region: Use cond_guard() in show_targetN() Fabio M. De Francesco
2024-02-05 17:13   ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240205142613.23914-1-fabio.maria.de.francesco@linux.intel.com \
    --to=fabio.maria.de.francesco@linux.intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=dan.j.williams@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox