From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <dan.j.williams@intel.com>,
<ira.weiny@intel.com>, <vishal.l.verma@intel.com>,
<alison.schofield@intel.com>, <dave@stgolabs.net>
Subject: Re: [PATCH v5 0/4] cxl: Fix memdev qos_class sysfs attributes
Date: Thu, 15 Feb 2024 16:17:09 +0000 [thread overview]
Message-ID: <20240215161709.000053c0@Huawei.com> (raw)
In-Reply-To: <20240206190431.1810289-1-dave.jiang@intel.com>
On Tue, 6 Feb 2024 12:03:36 -0700
Dave Jiang <dave.jiang@intel.com> wrote:
> v5:
> - Only update the perf sysfs groups (Dan)
> - Remove unnecessary type cast (Jonathan)
>
> v4:
> - Fix resetting of dpa_perf (Wonjae)
> - Change cxl_qos_match() to return bool. (Jonathan)
> - Remove unnecessary void * casting. (Jonathan)
> - Replace open code with sysfs_update_groups() helper. (Jonathan)
>
> This series provides fixes to the memdev qos_class sysfs attributes. The
> current code emits duplicate sysfs attribute under the same directory and
> the ram qos_class clobbers the pmem qos_class. Move the attributes under
> static definitions and allow the attributes to show up under ram and pmem
> directory individually.
>
> The series also adds cxl_test support in order to allow CXL CLI add a unit
> test for qos_class attributes.
I see Dan has this queued up already but fwiw (excluding patch 4 because
I've not looked at the cxl-test stuff for a while).
For patches 1-3
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2024-02-15 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 19:03 [PATCH v5 0/4] cxl: Fix memdev qos_class sysfs attributes Dave Jiang
2024-02-06 19:03 ` [PATCH v5 1/4] cxl: Change 'struct cxl_memdev_state' *_perf_list to single 'struct cxl_dpa_perf' Dave Jiang
2024-02-06 19:03 ` [PATCH v5 2/4] cxl: Remove unnecessary type cast in cxl_qos_class_verify() Dave Jiang
2024-02-06 19:03 ` [PATCH v5 3/4] cxl: Fix sysfs export of qos_class for memdev Dave Jiang
2024-02-06 19:03 ` [PATCH v5 4/4] cxl/test: Add support for qos_class checking Dave Jiang
2024-02-15 16:17 ` Jonathan Cameron [this message]
2024-02-15 16:18 ` [PATCH v5 0/4] cxl: Fix memdev qos_class sysfs attributes Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215161709.000053c0@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox