From: "Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org
Cc: linux-cxl@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Dave Jiang <dave.jiang@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Ira Weiny <ira.weiny@intel.com>,
"Fabio M. De Francesco"
<fabio.maria.de.francesco@linux.intel.com>
Subject: [PATCH 0/3 v5] Add cond_guard() to conditional guards
Date: Sat, 17 Feb 2024 11:59:01 +0100 [thread overview]
Message-ID: <20240217105904.1912368-1-fabio.maria.de.francesco@linux.intel.com> (raw)
Add cond_guard() macro to conditional guards. Show how to use it by
converting two functions in drivers/cxl to replace open-coded up_read()
in show_targetN() and in cxl_inject_poison() and avoid to 'goto' to a
cleanup block marked by an 'out' label. The second conversion is added
with v5 to show that the most recent implementation of cond_guard() can
also be used more than once in the same scope.
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Suggested-by: Ira Weiny <ira.weiny@intel.com>
Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Fabio M. De Francesco <fabio.maria.de.francesco@linux.intel.com>
---
Changes from RFC v5:
Changed the interface of cond_guard() to take a statement or
statement-expression as its second argument to conform to Dan's
suggestion (thanks).
Changes from v1:
Fixed a grammar error in the commit message of 1/2; replaced the
name of the second argument of cond_guard() with '_fail'
according to Jonathan's comments (thanks).
Changes from v2:
Changed macro's implementation to add an 'else' to protect
against it being used incorrectly within another if() block.
Suggested by Dan (thanks). The Reviewed-by tags on 1/2 are not
forwarded because the implementation of cond_guard() has changed.
Removed a redundant 'else' from show_targetN() in 2/2.
Changes from v3:
Added braces around empty body in an 'else' statement in
cond_guard(). Added Reviewed-by tags (Dave, Ira - thanks).
Changes from v4:
Made it possible to call cond_guard() more than once in the same
scope. Jonathan suggested a more elegant implementation than the
one I had thought. It uses an exhisting helper instead of creating
an ad hoc one (thanks). Added a second conversion to show that
cond_guard() can be used twice in the same scope. Deleted the
Reviewed-by tags from 1/3 since the implementation of cond_guard()
has significantly been reworked to allow multiple calls.
Fabio M. De Francesco (3):
cleanup: Add cond_guard() to conditional guards
cxl/region: Use cond_guard() in show_targetN()
cxl/memdev: Use cond_guard() in cxl_inject_poison()
drivers/cxl/core/memdev.c | 19 +++++--------------
drivers/cxl/core/region.c | 16 ++++------------
include/linux/cleanup.h | 20 ++++++++++++++++++++
3 files changed, 29 insertions(+), 26 deletions(-)
--
2.43.2
next reply other threads:[~2024-02-17 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 10:59 Fabio M. De Francesco [this message]
2024-02-17 10:59 ` [PATCH 1/3 v5] cleanup: Add cond_guard() to conditional guards Fabio M. De Francesco
2024-02-19 11:51 ` Jonathan Cameron
2024-02-22 18:27 ` Dave Jiang
2024-02-17 10:59 ` [PATCH 2/3 v5] cxl/region: Use cond_guard() in show_targetN() Fabio M. De Francesco
2024-02-17 10:59 ` [PATCH 3/3 v5] cxl/memdev: Use cond_guard() in cxl_inject_poison() Fabio M. De Francesco
2024-02-19 11:52 ` Jonathan Cameron
2024-02-22 18:27 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240217105904.1912368-1-fabio.maria.de.francesco@linux.intel.com \
--to=fabio.maria.de.francesco@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox