From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 925C217B4F3; Thu, 2 May 2024 18:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714674579; cv=none; b=TrDeln8X6SPajPQ/k6KZVxRbz7nhBE6S237RCGKmWEgMC/3c2tp63bM+18zUdPObBodtoaFwhSAapE4g5VIoT0Cdl4Xi15T/29FNEBAlS39fhmNAWLK+trAhi1G2G8K3xSSmmfmnisjefMCFmcRwoSk0rPF79jEeUHDdH1lXIXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714674579; c=relaxed/simple; bh=n9wAFg7ArJZyYeoIbQJLeJ0JAPxeyk3nvUQsM+OediM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O3coLk3t917gJeVeWnwinWaK2tMXcEQVF/Ff21oDJKnZHdeSmP8Ng/cfU72LqNFHBeW/2p0Gi7Z8cWA+BX9UnarR2e3hLzye8+h38+U1vafmaCPhshxlJngWGSSzVvlitALYb2BcAN7jiKx7vhCYeZCHEP1vU4WgvvYC3EZDjI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=s37Qe4Sx; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="s37Qe4Sx" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=h5sk8LNA2G99FVrO1CPwUk4qXbxohKMDilL9oo/KuyQ=; b=s37Qe4Sx/9fEEjKGVG8fSm1mji rlgji2926uZvD6z9e6MYMCwSiPfka7ZP9fOKcPe/l0czLhwwWVuJIrMpfAmnz044AahICjhackJdo 6RtIaJPwxzoDej6D5Tfxwy1EpVsfFPrvwlYs5qda3gL9tftRJLDalAQkgU/6Z1vzv0N0cL1kqwbkP RJK4Z1jUuhmQ6byaXIegdWEkV6QPfDPt5Zdop75sM62rORyVWRo6Gmltou4XWB2yd+0BgADH6U0cQ Apk0yiI7SZmQJlYw6c8buwo445QKJbgStrw1KN4nhQLkKtZz1sgAvum15GLv5dqMdrK8B8OU4ZOC+ 6wsBoiEA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1s2bBH-009dTw-2t; Thu, 02 May 2024 18:29:20 +0000 Date: Thu, 2 May 2024 19:29:19 +0100 From: Al Viro To: John Groves Cc: Jonathan Corbet , Jonathan Cameron , Dan Williams , Vishal Verma , Dave Jiang , Christian Brauner , Jan Kara , Matthew Wilcox , linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, John Groves , john@jagalactic.com, Dave Chinner , Christoph Hellwig , dave.hansen@linux.intel.com, gregory.price@memverge.com, Randy Dunlap , Jerome Glisse , Aravind Ramesh , Ajay Joshi , Eishan Mirakhur , Ravi Shankar , Srinivasulu Thanneeru , Luis Chamberlain , Amir Goldstein , Chandan Babu R , Bagas Sanjaya , "Darrick J . Wong" , Kent Overstreet , Steve French , Nathan Lynch , Michael Ellerman , Thomas Zimmermann , Julien Panis , Stanislav Fomichev , Dongsheng Yang Subject: Re: [RFC PATCH v2 10/12] famfs: Introduce file_operations read/write Message-ID: <20240502182919.GI2118490@ZenIV> References: <4584f1e26802af540a60eadb70f42c6ac5fe4679.1714409084.git.john@groves.net> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4584f1e26802af540a60eadb70f42c6ac5fe4679.1714409084.git.john@groves.net> Sender: Al Viro On Mon, Apr 29, 2024 at 12:04:26PM -0500, John Groves wrote: > +const struct file_operations famfs_file_operations = { > + .owner = THIS_MODULE, Not needed, unless you are planning something really weird (using it for misc device, etc.)