From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BF07195999 for ; Fri, 7 Jun 2024 14:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717771232; cv=none; b=FVbD6mAVPZ1xk0VaX6bx9o681Mdj4+UMEXB3Fr4Ze7BDEMACrycflrvoqVZe1C0UwuJguaF5H+/DYsq5I6RYiaC14sKZqdOxkTs7BBsRUb+zRO5QYwYS+8x1p9ety2+fppAJcwhKcLH/xrv0d7wY96sCxFvOj1o6RIQwmZEKXAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717771232; c=relaxed/simple; bh=lV6CP6XM3QC9frLsZnN6THFxsaNqog2tstJy/k8+LFw=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=htdpfEbBE+2E3GAU+QSlB1w4CfAlvU629CIi4ZfdpsmxJuL6JLihF4Jzk6vdYwy6EAX3oKwzq4yUlVrScZ1Uu40fWK9Tglx/eLfsWtFVQXAS2hZCIUeQMKb+7YmkVmfYhBvpJqw0LoqM2+t+/KB4dWv30MFWYHhFRn2NmGrFzb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VwkJb6GKhz6GBTy; Fri, 7 Jun 2024 22:35:43 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id F25A1140C98; Fri, 7 Jun 2024 22:40:26 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 7 Jun 2024 15:40:26 +0100 Date: Fri, 7 Jun 2024 15:40:25 +0100 From: Jonathan Cameron To: CC: Davidlohr Bueso , Dave Jiang , Vishal Verma , Ira Weiny , Dan Williams , Subject: Re: [PATCH v2 1/4] cxl/core: Rename cxl_trace_hpa() to cxl_translate() Message-ID: <20240607154025.0000786d@Huawei.com> In-Reply-To: <27686c91cf4f8b09991534708f6ad2dfc2443af1.1715192606.git.alison.schofield@intel.com> References: <27686c91cf4f8b09991534708f6ad2dfc2443af1.1715192606.git.alison.schofield@intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To lhrpeml500005.china.huawei.com (7.191.163.240) On Wed, 8 May 2024 11:47:50 -0700 alison.schofield@intel.com wrote: > From: Alison Schofield > > Although cxl_trace_hpa() is used to populate TRACE EVENTs with HPA > addresses, the work it performs is a translation (dpa->hpa), not a > trace. Rename it. Since this is the only translate work in CXL, > drop the _hpa suffix in the rename. > > Suggested-by: Dan Williams > Signed-off-by: Alison Schofield Maybe makes some sense to keep the direction in the name? I can see for things like PPR we may need to go HPA to DPA as it'll be based on error counts that may be reported in HPA. So Friday bikeshedding time. cxl_dpa_to_hpa()? > --- > drivers/cxl/core/core.h | 4 ++-- > drivers/cxl/core/mbox.c | 2 +- > drivers/cxl/core/region.c | 2 +- > drivers/cxl/core/trace.h | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h > index 625394486459..8ceebd3b51d2 100644 > --- a/drivers/cxl/core/core.h > +++ b/drivers/cxl/core/core.h > @@ -28,12 +28,12 @@ int cxl_region_init(void); > void cxl_region_exit(void); > int cxl_get_poison_by_endpoint(struct cxl_port *port); > struct cxl_region *cxl_dpa_to_region(const struct cxl_memdev *cxlmd, u64 dpa); > -u64 cxl_trace_hpa(struct cxl_region *cxlr, const struct cxl_memdev *cxlmd, > +u64 cxl_translate(struct cxl_region *cxlr, const struct cxl_memdev *cxlmd, > u64 dpa); > > #else > static inline u64 > -cxl_trace_hpa(struct cxl_region *cxlr, const struct cxl_memdev *cxlmd, u64 dpa) > +cxl_translate(struct cxl_region *cxlr, const struct cxl_memdev *cxlmd, u64 dpa) > { > return ULLONG_MAX; > } > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 2626f3fff201..edc54a1ca298 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -878,7 +878,7 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd, > dpa = le64_to_cpu(evt->common.phys_addr) & CXL_DPA_MASK; > cxlr = cxl_dpa_to_region(cxlmd, dpa); > if (cxlr) > - hpa = cxl_trace_hpa(cxlr, cxlmd, dpa); > + hpa = cxl_translate(cxlr, cxlmd, dpa); > > if (event_type == CXL_CPER_EVENT_GEN_MEDIA) > trace_cxl_general_media(cxlmd, type, cxlr, hpa, > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index 00a9f0eef8dd..245edf748906 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -2797,7 +2797,7 @@ static u64 cxl_dpa_to_hpa(u64 dpa, struct cxl_region *cxlr, > return hpa; > } > > -u64 cxl_trace_hpa(struct cxl_region *cxlr, const struct cxl_memdev *cxlmd, > +u64 cxl_translate(struct cxl_region *cxlr, const struct cxl_memdev *cxlmd, > u64 dpa) > { > struct cxl_region_params *p = &cxlr->params; > diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h > index 07a0394b1d99..6925a6a31f01 100644 > --- a/drivers/cxl/core/trace.h > +++ b/drivers/cxl/core/trace.h > @@ -704,7 +704,7 @@ TRACE_EVENT(cxl_poison, > if (cxlr) { > __assign_str(region, dev_name(&cxlr->dev)); > memcpy(__entry->uuid, &cxlr->params.uuid, 16); > - __entry->hpa = cxl_trace_hpa(cxlr, cxlmd, > + __entry->hpa = cxl_translate(cxlr, cxlmd, > __entry->dpa); > } else { > __assign_str(region, "");