From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31C8C128812 for ; Fri, 21 Jun 2024 17:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718989690; cv=none; b=HuCvbCi3AeLLEh4ktEwvv5WFJsgK9gNoRfRte6ajdRDtaV+vOqjJ/3wg+9sG5QSCggS3X+0liG37NXdrcQ+3jOJKa5bTBRjUlsaXNgHyZKhkDTnWonXLmf78MbQ7Hc6eDopApTH86XERHxAC51nfkorwTcqIens6MOEiNdLmyBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718989690; c=relaxed/simple; bh=AV6vFhFxnqjRFkNDrz+Msl6I++cnqPnRz9Q+8b/LYec=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nUzCX7v+fRmg1J6Elc6Jf5HktQKiIM7RrApz5/w0t0BThJmmDoo/OQNmPuw6ZOMJ17QcSeGyL6GTYAfvgAU/FkZNRHc7Y3uDvEiGPn4jfrMlo+//53p2bMoB56qpybWRfadL7nHga4UO1lnhr6OIbWJcZJsdZiYwn+f9E0BttVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4W5P1Q61BRz6K6KV; Sat, 22 Jun 2024 01:07:38 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id E0EC7140A30; Sat, 22 Jun 2024 01:08:05 +0800 (CST) Received: from localhost (10.122.19.247) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 21 Jun 2024 18:08:05 +0100 Date: Fri, 21 Jun 2024 18:08:04 +0100 From: Jonathan Cameron To: Davidlohr Bueso CC: fan , , , , Subject: Re: [PATCH v2 -qemu] hw/cxl: Support firmware updates Message-ID: <20240621180804.00004876@huawei.com> In-Reply-To: <20240621175818.00007705@huawei.com> References: <20240205172942.13343-1-dave@stgolabs.net> <20240319204818.p6qbkyktgsadmkhi@offworld> <20240621175818.00007705@huawei.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) On Fri, 21 Jun 2024 17:58:18 +0100 Jonathan Cameron wrote: > On Tue, 19 Mar 2024 13:48:18 -0700 > Davidlohr Bueso wrote: > > > On Tue, 19 Mar 2024, fan wrote: > > > > >> +/* CXL r3.1 section 8.2.9.3.2: Transfer FW (Opcode 0201h) */ > > >> +#define CXL_FW_XFER_ALIGNMENT 128 > > >> + > > >> +#define CXL_FW_XFER_ACTION_FULL 0x0 > > >> +#define CXL_FW_XFER_ACTION_INIT 0x1 > > >> +#define CXL_FW_XFER_ACTION_CONTINUE 0x2 > > >> +#define CXL_FW_XFER_ACTION_END 0x3 > > >> +#define CXL_FW_XFER_ACTION_ABORT 0x4 > > > > > >The above definitions have "tab" used, cannot pass checkpatch check. > > > > I was not aware of a checkpatch for qemu, will clean up. > > > > >> + > > >> +static CXLRetCode cmd_firmware_update_transfer(const struct cxl_cmd *cmd, > > >> + uint8_t *payload_in, > > >> + size_t len, > > >> + uint8_t *payload_out, > > >> + size_t *len_out, > > >> + CXLCCI *cci) > > >> +{ > > >> + struct { > > >> + uint8_t action; > > >> + uint8_t slot; > > >> + uint8_t caps; > > > > > >Based on table 8-66, I cannot find the field "caps" and it is unused. > > > > Hmm yep don't know how that snuck in, will get rid of it. > > > > Thanks, > > Davidlohr > > I fixed both on my tree. > Then dropped it when reading Davidlohr's reply and seeing there was more to do. Looking forward to v3 :) Jonathan