From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <linux-cxl@vger.kernel.org>, <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>, <qemu-devel@nongnu.org>,
Li Zhijian <lizhijian@fujitsu.com>
Cc: <linuxarm@huawei.com>
Subject: [PATCH 1/3] hw/cxl: Get rid of unused cfmw_list
Date: Tue, 2 Jul 2024 15:34:23 +0100 [thread overview]
Message-ID: <20240702143425.717452-2-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20240702143425.717452-1-Jonathan.Cameron@huawei.com>
From: Li Zhijian <lizhijian@fujitsu.com>
There is no user for this member. All '-M cxl-fmw.N' options have
been parsed and saved to CXLState.fixed_windows.
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
include/hw/cxl/cxl.h | 1 -
hw/cxl/cxl-host.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h
index 75e47b6864..e3ecbef038 100644
--- a/include/hw/cxl/cxl.h
+++ b/include/hw/cxl/cxl.h
@@ -43,7 +43,6 @@ typedef struct CXLState {
MemoryRegion host_mr;
unsigned int next_mr_idx;
GList *fixed_windows;
- CXLFixedMemoryWindowOptionsList *cfmw_list;
} CXLState;
struct CXLHost {
diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
index c5f5fcfd64..926d3d3da7 100644
--- a/hw/cxl/cxl-host.c
+++ b/hw/cxl/cxl-host.c
@@ -335,7 +335,6 @@ static void machine_set_cfmw(Object *obj, Visitor *v, const char *name,
for (it = cfmw_list; it; it = it->next) {
cxl_fixed_memory_window_config(state, it->value, errp);
}
- state->cfmw_list = cfmw_list;
}
void cxl_machine_init(Object *obj, CXLState *state)
--
2.43.0
next prev parent reply other threads:[~2024-07-02 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 14:34 [PATCH qemu 0/3] hw/cxl: Misc minor improvements Jonathan Cameron
2024-07-02 14:34 ` Jonathan Cameron [this message]
2024-07-05 1:04 ` [PATCH 1/3] hw/cxl: Get rid of unused cfmw_list Zhijian Li (Fujitsu)
2024-07-05 2:15 ` Zhao Liu
2024-07-05 2:29 ` Zhijian Li (Fujitsu)
2024-07-05 9:40 ` Jonathan Cameron
2024-07-02 14:34 ` [PATCH 2/3] hw/cxl/cxl-mailbox-utils: remove unneeded mailbox output payload space zeroing Jonathan Cameron
2024-07-02 14:34 ` [PATCH 3/3] hw/cxl: Check for multiple mappings of memory backends Jonathan Cameron
2024-07-05 11:41 ` [PATCH qemu 0/3] hw/cxl: Misc minor improvements Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702143425.717452-2-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=armbru@redhat.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lizhijian@fujitsu.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox