From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>,
<qemu-devel@nongnu.org>
Cc: <linuxarm@huawei.com>, <linux-cxl@vger.kernel.org>,
<marcel.apfelbaum@gmail.com>, Dave Jiang <dave.jiang@intel.com>,
Huang Ying <ying.huang@intel.com>,
Michael Roth <michael.roth@amd.com>, <fan.ni@samsung.com>
Subject: [RFC qemu 1/6] hw/pci-bridge/cxl_root_port: Provide x-speed and x-width properties.
Date: Fri, 12 Jul 2024 13:24:09 +0100 [thread overview]
Message-ID: <20240712122414.1448284-2-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20240712122414.1448284-1-Jonathan.Cameron@huawei.com>
Approach copied from gen_pcie_root_port.c
Previously the link defaulted to a maximum of 2.5GT/s and 1x. Enable setting
it's maximum values. The actual value after 'training' will depend on the
downstream device configuration.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
hw/pci-bridge/cxl_root_port.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/pci-bridge/cxl_root_port.c b/hw/pci-bridge/cxl_root_port.c
index 2dd10239bd..5e2156d7ba 100644
--- a/hw/pci-bridge/cxl_root_port.c
+++ b/hw/pci-bridge/cxl_root_port.c
@@ -24,6 +24,7 @@
#include "hw/pci/pcie_port.h"
#include "hw/pci/msi.h"
#include "hw/qdev-properties.h"
+#include "hw/qdev-properties-system.h"
#include "hw/sysbus.h"
#include "qapi/error.h"
#include "hw/cxl/cxl.h"
@@ -206,6 +207,10 @@ static Property gen_rp_props[] = {
-1),
DEFINE_PROP_SIZE("pref64-reserve", CXLRootPort, res_reserve.mem_pref_64,
-1),
+ DEFINE_PROP_PCIE_LINK_SPEED("x-speed", PCIESlot,
+ speed, PCIE_LINK_SPEED_64),
+ DEFINE_PROP_PCIE_LINK_WIDTH("x-width", PCIESlot,
+ width, PCIE_LINK_WIDTH_32),
DEFINE_PROP_END_OF_LIST()
};
--
2.43.0
next prev parent reply other threads:[~2024-07-12 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 12:24 [RFC qemu 0/6] hw/cxl: Link speed and width control Jonathan Cameron
2024-07-12 12:24 ` Jonathan Cameron [this message]
2025-05-01 21:49 ` [RFC qemu 1/6] hw/pci-bridge/cxl_root_port: Provide x-speed and x-width properties Philippe Mathieu-Daudé
2024-07-12 12:24 ` [RFC qemu 2/6] hw/pci-bridge/cxl_upstream: " Jonathan Cameron
2024-07-12 12:24 ` [RFC qemu 3/6] hw/pcie: Factor out PCI Express link register filing common to EP Jonathan Cameron
2024-07-12 12:24 ` [RFC qemu 4/6] hw/pcie: Provide a utility function for control of EP / SW USP link Jonathan Cameron
2024-07-12 12:24 ` [RFC qemu 5/6] hw/mem/cxl-type3: Add properties to control link speed and width Jonathan Cameron
2024-07-12 12:24 ` [RFC qemu 6/6] hw/pci-bridge/cxl-upstream: " Jonathan Cameron
2024-08-28 17:00 ` [RFC qemu 0/6] hw/cxl: Link speed and width control Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712122414.1448284-2-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=armbru@redhat.com \
--cc=dave.jiang@intel.com \
--cc=fan.ni@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox