Re: [RFC PATCH 11/13] fwctl/cxl: Add query commands software command for ->fw_rpc()

Jonathan Cameron
2024-07-29T11:48:35Z

On Thu, 18 Jul 2024 14:32:29 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> Add a software command through the ->fw_rpc() in order for the user to
> retrieve information about the commands that are supported. In this
> instance only 3 commands are supported: Get Supported Features, Get
> Feature, and Set Feature.
>
> The expected flow of operation is to send the call first with 0 set
> to the n_commands parameter to indicate query of total commands
> available. And then a second call provides the number of commands
> to retrieve with the appropriate amount of memory allocated to store
> information about the commands.

We will need another layer of querying to query what features
are supported for each type of access. Get is probably always reasonable
in some cases we may want to block Set even with taint as it may provide
a nasty footgun.

Jonathan