Re: [RFC PATCH 11/13] fwctl/cxl: Add query commands software command for ->fw_rpc()

Jason Gunthorpe
2024-08-08T12:56:42Z

On Mon, Jul 22, 2024 at 04:23:14PM -0700, Dave Jiang wrote:
>
>
> On 7/22/24 8:24 AM, Jason Gunthorpe wrote:
> > On Thu, Jul 18, 2024 at 02:32:29PM -0700, Dave Jiang wrote:
> >> Add a software command through the ->fw_rpc() in order for the user to
> >> retrieve information about the commands that are supported. In this
> >> instance only 3 commands are supported: Get Supported Features, Get
> >> Feature, and Set Feature.
> >
> > I wonder if we should try to have a seperate API for this, knowing
> > what command numbers are supported seems sort of general to me?
>
> Probably a reasonable thing to add. Will you add something in the
> fwctl v3 or should I try to add something in my series for fwctl?
>
> Wonder if we should also return some sort of fwctl commonly defined
> effects field for each command.

I'm not sure I fully understand what CXL would like here, including
Jonathan's remakrs too. Can you give some short draft?

Jason