Re: [RFC PATCH 08/13] fwctl/cxl: Add driver for CXL mailbox for handling CXL features commands

Jason Gunthorpe
2024-09-26T17:37:28Z

On Tue, Sep 24, 2024 at 04:44:19PM -0700, Dave Jiang wrote:

> >> @@ -1030,6 +1032,7 @@ static const struct file_operations cxl_memdev_fops = {
> >> struct cxl_memdev *devm_cxl_add_memdev(struct device *host,
> >> struct cxl_dev_state *cxlds)
> >> {
> >> + struct auxiliary_device *adev;
> >
> > Why an auxdev? It can be any convienient dev to which a driver
> > will bind. Why not spin one on the CXL bus for this purpose?

IMHO bus members should adhere to some kinds of rules about the bus
itself. Devices should have the same set of paramters/etc. I don't
know what cxl_bus is, but I'd be surprised that something with that
name has SW only entities on it as devices??

aux bus was specifically for SW only entities that are just for
linking software components.

Jason