Re: [PATCH 1/3] cxl/pci: Rename cxl_setup_parent_dport() and cxl_dport_map_regs()

Li, Ming4
2024-08-28T01:36:44Z

On 8/27/2024 10:56 PM, Jonathan Cameron wrote:
> On Tue, 27 Aug 2024 04:57:53 +0000
> Li Ming <ming4.li@intel.com> wrote:
>
>> The name of cxl_setup_parent_dport() function is not clear, the function
>> is used to initialize AER and RAS capabilities on a dport, therefore,
>> rename the function to cxl_dport_init_aer(), it is easier for user to
>> understand what the function does. Besides, adjust the order of the
>> function parameters, the subject of cxl_dport_init_aer() is a cxl port,
> Hmm. It's not just aer, so maybe cxl_dport_init_ras_reporting() is broader
> naming that incorporates the fact this includes the CXL specific stuff.
> Obvious that might be used to get more detail on an AER error report,
> but it's not part of aer.
>
> Don't want to just use _ras() because of all the ras control stuff that
> isn't related to this function.
>
> Otherwise LGTM.
>
> Jonathan

Thank you for review, will do it in v2.

>> so a struct cxl_dport as the first parameter of the function should be
>> better.
>>
>> cxl_dport_map_regs() is used to map CXL RAS capability on a cxl dport,
>> using cxl_dport_map_ras() as the function name.
>>
>> Signed-off-by: Li Ming <ming4.li@intel.com>